Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl core::error::Error instead of std::error::Error #333

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Impl core::error::Error instead of std::error::Error #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions derive_builder_core/src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ pub struct Builder<'a> {
/// Doc-comment of the builder struct.
pub doc_comment: Option<syn::Attribute>,
/// Whether or not a libstd is used.
#[allow(dead_code)]
pub std: bool,
}

Expand Down Expand Up @@ -294,11 +295,9 @@ impl<'a> ToTokens for Builder<'a> {
}
));

if self.std {
tokens.append_all(quote!(
impl std::error::Error for #builder_error_ident {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ≥1.81, is there some blanket impl on std::error::Error that means all core::error::Error impls are satisfactory? If not, do we need to emit both impls to avoid breaking compatibility?

));
}
tokens.append_all(quote!(
impl core::error::Error for #builder_error_ident {}
));
}
}
}
Expand Down