v1.0.4 (#20)

coinbase · Jan 29, 2024 · 0b7522d · 0b7522d
1 parent 681ab17
commit 0b7522d
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## [1.0.4] - 2024-JAN-29
+
+### Fixed
+- Fixed bug where `move_portfolio_funds` params were set incorrectly
+
 ## [1.0.3] - 2024-JAN-19
 
 ### Changed

diff --git a/coinbase/__version__.py b/coinbase/__version__.py
@@ -1 +1 @@
-__version__ = "1.0.3"
+__version__ = "1.0.4"
diff --git a/coinbase/rest/portfolios.py b/coinbase/rest/portfolios.py
@@ -59,11 +59,11 @@ def move_portfolio_funds(
 
     data = {
         "funds": {
-            "amount": value,
+            "value": value,
             "currency": currency,
         },
-        "source_portfolio_id": source_portfolio_uuid,
-        "target_portfolio_id": target_portfolio_uuid,
+        "source_portfolio_uuid": source_portfolio_uuid,
+        "target_portfolio_uuid": target_portfolio_uuid,
     }
 
     return self.post(endpoint, data=data, **kwargs)

diff --git a/tests/rest/test_portfolios.py b/tests/rest/test_portfolios.py
@@ -3,7 +3,8 @@
 from requests_mock import Mocker
 
 from coinbase.rest import RESTClient
-from tests.constants import TEST_API_KEY, TEST_API_SECRET
+
+from ..constants import TEST_API_KEY, TEST_API_SECRET
 
 
 class PortfoliosTest(unittest.TestCase):
@@ -83,9 +84,9 @@ def test_move_portfolio_funds(self):
             self.assertEqual(
                 captured_json,
                 {
-                    "funds": {"amount": "100", "currency": "USD"},
-                    "source_portfolio_id": "1234",
-                    "target_portfolio_id": "5678",
+                    "funds": {"value": "100", "currency": "USD"},
+                    "source_portfolio_uuid": "1234",
+                    "target_portfolio_uuid": "5678",
                 },
             )
             self.assertEqual(move, expected_response)