Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment #28

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Update environment #28

merged 2 commits into from
Oct 2, 2024

Conversation

scharlottej13
Copy link
Contributor

Updating some of these packages since dask-expr was incorporated into dask dataframe. The only one I had some trouble with was dask-deltatable (see dask-contrib/dask-deltatable#81)

environment.yml Outdated
# - dask-deltatable
- pip
- pip:
- git+https://github.com/fjetter/dask-deltatable.git@dask_expr
- git+https://github.com/dask-contrib/dask-deltatable.git@7706c22aa07f978f481ca4996dce8ca0121c812e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like dask-deltatable==0.3.3 should fix the issue you ran into? dask-contrib/dask-deltatable#81

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup that works!

environment.yml Outdated Show resolved Hide resolved
@@ -17,8 +16,8 @@ dependencies:
- s3fs
- universal_pathlib <0.2.0
- boto3
- deltalake=0.15.3
- deltalake >=0.18
# - dask-deltatable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# - dask-deltatable
- dask-deltatable=0.3.3

Comment on lines 22 to +23
- pip:
- git+https://github.com/fjetter/dask-deltatable.git@dask_expr
- dask-deltatable==0.3.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to pip install it for things to work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm that's strange but 🤷

@jrbourbeau jrbourbeau merged commit bf5333a into coiled:main Oct 2, 2024
1 check passed
@scharlottej13 scharlottej13 deleted the patch-2 branch October 2, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants