Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: asquare import, commit: c3c805e0f41046b1c2a027dcdaa8a352715add03 #1

Merged
merged 35 commits into from
Nov 4, 2024
Merged

feat: asquare import, commit: c3c805e0f41046b1c2a027dcdaa8a352715add03 #1

merged 35 commits into from
Nov 4, 2024

Conversation

psiotwo
Copy link
Collaborator

@psiotwo psiotwo commented Sep 23, 2024 •
edited
Loading

This PR contains the extracted components from Asquare - the goal was to get the import with the same API as for Asquare.

migration scope:

  • migrated components as dedicated modules:
    • connectors:
      • GraphDB
      • Virtuoso
      • Stardog
      • Fuseki
      • In-memory Jena - InternalRdfStoreService migrated but without setPreLoadLocations
    • spring provider
  • removed dependencies on Spring, Guava, Assertj, Joda-time for connectors
  • RdfStoreService implementations deprecated
  • basic tests + tests for these connectors:
    • In-memory Jena
    • Fuseki
    • GraphDB
  • tests missing for:
    • Virtuoso, Stardog

not migrated:

@psiotwo psiotwo marked this pull request as ready for review October 7, 2024 08:44
@natan-cox-cognizone
Copy link

@psiotwo I will create an issue for Datasets. seems relevant. I know I "recently" used it.

natan-cox-cognizone
natan-cox-cognizone reviewed Oct 30, 2024
View reviewed changes
Copy link

@natan-cox-cognizone natan-cox-cognizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still in progress but saving for now.

...z-connectors-common/src/main/java/zone/cogni/semanticz/connectors/general/SparqlService.java Outdated Show resolved Hide resolved
...z-connectors-common/src/main/java/zone/cogni/semanticz/connectors/general/SparqlService.java Show resolved Hide resolved
...z-connectors-common/src/main/java/zone/cogni/semanticz/connectors/general/SparqlService.java Show resolved Hide resolved
...z-connectors-common/src/main/java/zone/cogni/semanticz/connectors/general/SparqlService.java Show resolved Hide resolved
...z-connectors-common/src/main/java/zone/cogni/semanticz/connectors/general/SparqlService.java Show resolved Hide resolved
...rs-common/src/main/java/zone/cogni/semanticz/connectors/utils/AbstractSparqlServiceTest.java Show resolved Hide resolved
...rs-common/src/main/java/zone/cogni/semanticz/connectors/utils/TripleSerializationFormat.java Show resolved Hide resolved
...amemory/src/main/java/zone/cogni/semanticz/connectors/jenamemory/JenaModelSparqlService.java Show resolved Hide resolved
...z-connectors-common/src/main/java/zone/cogni/semanticz/connectors/general/SparqlService.java Outdated Show resolved Hide resolved
@psiotwo psiotwo merged commit de41061 into develop Nov 4, 2024
1 check passed
@psiotwo psiotwo deleted the feat/import-from-asquare branch November 17, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-lukashov alexey-lukashov alexey-lukashov approved these changes

@natan-cox-cognizone natan-cox-cognizone natan-cox-cognizone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psiotwo @natan-cox-cognizone @alexey-lukashov