Feature onboard developer form b2 #744
Conversation
|
@John-Paul-Larkin is attempting to deploy a commit to the Codú Team on Vercel. A member of the Team first needs to authorize it. |
|
This was my first time to reconcile a branch divergence. It was only the prisma file, so I think it should be fine. |
Actually, I am really starting to doubt myself, so please check this to be sure :) |
Don't panic! Let me pull this and make sure it's all good. Might be later before I get it tested. |
|
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Commits
Files that changed from the base of the PR and between e9a4edf and 290023391a2c57f058141325573c869de04f6c09 commits.Files selected (7)
- app/alpha/additional-details/_client.tsx (1)
- app/alpha/additional-details/actions.ts (1)
- app/alpha/additional-details/page.tsx (1)
- app/alpha/additional-details/selectOptions.ts (1)
- prisma/migrations/20240218201356_additional_user_details/migration.sql (1)
- prisma/schema.prisma (1)
- schema/additionalUserDetails.ts (1)
Files not summarized due to errors (7)
- app/alpha/additional-details/_client.tsx (diff tokens exceeds limit)
- prisma/migrations/20240218201356_additional_user_details/migration.sql (nothing obtained from openai)
- app/alpha/additional-details/page.tsx (nothing obtained from openai)
- schema/additionalUserDetails.ts (nothing obtained from openai)
- prisma/schema.prisma (nothing obtained from openai)
- app/alpha/additional-details/actions.ts (nothing obtained from openai)
- app/alpha/additional-details/selectOptions.ts (nothing obtained from openai)
Files not reviewed due to errors (6)
- app/alpha/additional-details/actions.ts (no response)
- prisma/schema.prisma (no response)
- app/alpha/additional-details/page.tsx (no response)
- schema/additionalUserDetails.ts (no response)
- prisma/migrations/20240218201356_additional_user_details/migration.sql (no response)
- app/alpha/additional-details/selectOptions.ts (no response)
Files skipped from review due to trivial changes (1)
- app/alpha/additional-details/_client.tsx (diff too large)
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
|
Warning CodeRabbit GitHub Action DetectedThe repository is using both CodeRabbit Pro and CodeRabbit Open Source (via GitHub Actions), which is not recommended as it may lead to duplicate comments and extra noise. Please remove the CodeRabbit GitHub Action. WalkthroughThe recent update introduces a comprehensive system for handling additional user sign-up details. It encompasses a new React component for collecting extensive user information during registration, a backend function for form submission and database updates, schema changes for additional user details, and predefined select options for form fields. This enhancement aims to enrich user profiles by capturing detailed demographic, work, and education information. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 12
Configuration used: CodeRabbit UI
Commits
Files that changed from the base of the PR and between e4fd410 and ccc52b45a4409fd278b3d5f1ab7e99600dc13fa0.Files selected for processing (7)
- app/alpha/additional-details/_client.tsx (1 hunks)
- app/alpha/additional-details/actions.ts (1 hunks)
- app/alpha/additional-details/page.tsx (1 hunks)
- app/alpha/additional-details/selectOptions.ts (1 hunks)
- prisma/migrations/20240218201356_additional_user_details/migration.sql (1 hunks)
- prisma/schema.prisma (1 hunks)
- schema/additionalUserDetails.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- app/alpha/additional-details/selectOptions.ts
Additional comments: 7
prisma/migrations/20240218201356_additional_user_details/migration.sql (1)
- 11-11: Dropping the default value for
isEventOrganiserin theMembershiptable could impact the application's behavior if the codebase assumes a default value for this column. Ensure that all insertions into theMembershiptable explicitly set a value forisEventOrganiser.app/alpha/additional-details/page.tsx (1)
- 1-5: Ensure that all imported modules are used within the file. Unused imports can lead to unnecessary code bloat and potential confusion about the file's dependencies.
app/alpha/additional-details/actions.ts (1)
- 1-9: Verify that all imported modules and functions are utilized within the file. Unused imports can clutter the code and potentially introduce confusion about the file's dependencies.
prisma/schema.prisma (1)
- 78-114: The addition of new fields to the
Usermodel aligns with the PR's objectives to consolidate user details. Ensure that these fields are appropriately used throughout the application and that any necessary validations or constraints are applied at the database level or within the application logic. Additionally, consider the impact of these changes on existing data and whether any data migration or transformation is required.app/alpha/additional-details/_client.tsx (3)
- 1-20: The use of
"use client";at the top of the file is a good practice for Next.js 13, ensuring that the file is treated as a client component. This is crucial for optimal performance and correct behavior in Next.js applications.- 46-49: The setup for
useFormwithzodResolveris correctly implemented, ensuring that form validation is based on the schema defined for additional user details. This is a good practice for maintaining consistency and reliability in form data handling.- 717-755: The
SlideButtonscomponent is well-designed, offering flexibility with optionalhandleClickNextSlide,handleClickPreviousSlide, andisSubmitButtonprops. This design allows for reuse across different slides with varying requirements for navigation and submission. Good job on designing a reusable component.
| /* | ||
| Warnings: | ||
|
|
||
| - Made the column `eventDate` on table `Event` required. This step will fail if there are existing NULL values in that column. |
There was a problem hiding this comment.
The migration makes the eventDate column in the Event table required. This change could potentially cause the migration to fail if there are existing NULL values in that column. It's crucial to ensure that all existing data complies with this new constraint before applying the migration.
| ALTER TABLE "User" ADD COLUMN "course" TEXT, | ||
| ADD COLUMN "dateOfBirth" TIMESTAMP(3), | ||
| ADD COLUMN "firstName" TEXT, | ||
| ADD COLUMN "gender" TEXT, | ||
| ADD COLUMN "jobTitle" TEXT, | ||
| ADD COLUMN "levelOfStudy" TEXT, | ||
| ADD COLUMN "professionalOrStudent" TEXT, | ||
| ADD COLUMN "surname" TEXT, | ||
| ADD COLUMN "workplace" TEXT; |
There was a problem hiding this comment.
Adding multiple columns to the User table to consolidate user details is a significant change. Ensure that these new fields are properly integrated into the application's logic, especially regarding form submissions and data retrieval. Additionally, consider the impact on performance and storage, as well as the necessity of each field to avoid overloading the User model with too much responsibility.
| export default async function Page() { | ||
| const session = await getServerAuthSession(); | ||
| if (!session || !session.user) { | ||
| redirect("/get-started"); | ||
| } | ||
|
|
||
| const details = await prisma.user.findUnique({ | ||
| where: { | ||
| id: session.user.id, | ||
| }, | ||
| select: selectUserDetails, | ||
| }); | ||
|
|
||
| const detailsWithNullsRemoved = { | ||
| username: details?.username || "", | ||
| firstName: details?.firstName || "", | ||
| surname: details?.surname || "", | ||
| gender: details?.gender || "", | ||
| dateOfBirth: details?.dateOfBirth || undefined, | ||
| location: details?.location || "", | ||
| professionalOrStudent: details?.professionalOrStudent || "", | ||
| course: details?.course || "", | ||
| levelOfStudy: details?.levelOfStudy || "", | ||
| jobTitle: details?.jobTitle || "", | ||
| workplace: details?.workplace || "", | ||
| }; | ||
|
|
||
| return <Content details={detailsWithNullsRemoved} />; |
There was a problem hiding this comment.
The redirection logic in the absence of a session or user should use return redirect("/get-started"); to ensure that the function execution stops after the redirect. Without the return statement, the function might continue executing, leading to potential errors or unexpected behavior.
- redirect("/get-started");
+ return redirect("/get-started");Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| export default async function Page() { | |
| const session = await getServerAuthSession(); | |
| if (!session || !session.user) { | |
| redirect("/get-started"); | |
| } | |
| const details = await prisma.user.findUnique({ | |
| where: { | |
| id: session.user.id, | |
| }, | |
| select: selectUserDetails, | |
| }); | |
| const detailsWithNullsRemoved = { | |
| username: details?.username || "", | |
| firstName: details?.firstName || "", | |
| surname: details?.surname || "", | |
| gender: details?.gender || "", | |
| dateOfBirth: details?.dateOfBirth || undefined, | |
| location: details?.location || "", | |
| professionalOrStudent: details?.professionalOrStudent || "", | |
| course: details?.course || "", | |
| levelOfStudy: details?.levelOfStudy || "", | |
| jobTitle: details?.jobTitle || "", | |
| workplace: details?.workplace || "", | |
| }; | |
| return <Content details={detailsWithNullsRemoved} />; | |
| export default async function Page() { | |
| const session = await getServerAuthSession(); | |
| if (!session || !session.user) { | |
| return redirect("/get-started"); | |
| } | |
| const details = await prisma.user.findUnique({ | |
| where: { | |
| id: session.user.id, | |
| }, | |
| select: selectUserDetails, | |
| }); | |
| const detailsWithNullsRemoved = { | |
| username: details?.username || "", | |
| firstName: details?.firstName || "", | |
| surname: details?.surname || "", | |
| gender: details?.gender || "", | |
| dateOfBirth: details?.dateOfBirth || undefined, | |
| location: details?.location || "", | |
| professionalOrStudent: details?.professionalOrStudent || "", | |
| course: details?.course || "", | |
| levelOfStudy: details?.levelOfStudy || "", | |
| jobTitle: details?.jobTitle || "", | |
| workplace: details?.workplace || "", | |
| }; | |
| return <Content details={detailsWithNullsRemoved} />; |
| const detailsWithNullsRemoved = { | ||
| username: details?.username || "", | ||
| firstName: details?.firstName || "", | ||
| surname: details?.surname || "", | ||
| gender: details?.gender || "", | ||
| dateOfBirth: details?.dateOfBirth || undefined, | ||
| location: details?.location || "", | ||
| professionalOrStudent: details?.professionalOrStudent || "", | ||
| course: details?.course || "", | ||
| levelOfStudy: details?.levelOfStudy || "", | ||
| jobTitle: details?.jobTitle || "", | ||
| workplace: details?.workplace || "", | ||
| }; |
There was a problem hiding this comment.
The approach to remove nulls from user details is clear and straightforward. However, consider centralizing this logic in a utility function if similar patterns are used elsewhere in the codebase. This would improve maintainability and reduce code duplication.
| export async function handleFormSubmit(dataInput: TypeAdditionalDetailsSchema) { | ||
| const session = await getServerAuthSession(); | ||
| if (!session || !session.user) { | ||
| redirect("/get-started"); | ||
| } | ||
|
|
||
| try { | ||
| const validatedData = AdditionalDetailsSchema.parse(dataInput); | ||
|
|
||
| await prisma.user.update({ | ||
| where: { | ||
| id: session.user.id, | ||
| }, | ||
| data: { | ||
| firstName: validatedData.firstName, | ||
| surname: validatedData.surname, | ||
| username: validatedData.username, | ||
| location: validatedData.location, | ||
| gender: validatedData.gender, | ||
| dateOfBirth: validatedData.dateOfBirth, | ||
| professionalOrStudent: validatedData.professionalOrStudent, | ||
| workplace: validatedData.workplace, | ||
| jobTitle: validatedData.jobTitle, | ||
| levelOfStudy: validatedData.levelOfStudy, | ||
| course: validatedData.course, | ||
| }, | ||
| }); | ||
| return true; | ||
| } catch (error) { | ||
| console.error( | ||
| "Error updating the User and DeveloperDetails models:", | ||
| error, | ||
| ); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
The form submission handler correctly validates the input data and updates the user's details in the database. However, the error handling could be improved by providing more specific feedback to the user or logging detailed error information for debugging purposes. Additionally, consider handling potential exceptions from getServerAuthSession and prisma.user.update.
| if (!session) { | ||
| redirect("/get-started"); | ||
| } |
There was a problem hiding this comment.
Redirecting users who are not in a session directly in the component body can lead to unexpected behavior during server-side rendering (SSR) or static site generation (SSG) in Next.js. Consider moving this logic to a useEffect hook or using middleware for session checks to ensure compatibility with Next.js's rendering strategies.
- if (!session) {
- redirect("/get-started");
- }
+ useEffect(() => {
+ if (!session) {
+ redirect("/get-started");
+ }
+ }, [session]);Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| if (!session) { | |
| redirect("/get-started"); | |
| } | |
| useEffect(() => { | |
| if (!session) { | |
| redirect("/get-started"); | |
| } | |
| }, [session]); |
| const onFormSubmit = async (data: TypeAdditionalDetailsSchema) => { | ||
| const isSuccess = await handleFormSubmit(data); | ||
|
|
||
| if (isSuccess) { | ||
| toast.success("Saved"); | ||
| } | ||
| if (!isSuccess) { | ||
| toast.error("Error, saving was unsuccessful."); | ||
| } | ||
| }; |
There was a problem hiding this comment.
The onFormSubmit function correctly handles form submission and displays appropriate toast messages based on the success of the operation. However, consider adding error handling for potential exceptions thrown by handleFormSubmit to improve the robustness of your application.
const onFormSubmit = async (data: TypeAdditionalDetailsSchema) => {
try {
const isSuccess = await handleFormSubmit(data);
if (isSuccess) {
toast.success("Saved");
} else {
toast.error("Error, saving was unsuccessful.");
}
} catch (error) {
toast.error("An unexpected error occurred.");
}
};Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| const onFormSubmit = async (data: TypeAdditionalDetailsSchema) => { | |
| const isSuccess = await handleFormSubmit(data); | |
| if (isSuccess) { | |
| toast.success("Saved"); | |
| } | |
| if (!isSuccess) { | |
| toast.error("Error, saving was unsuccessful."); | |
| } | |
| }; | |
| const onFormSubmit = async (data: TypeAdditionalDetailsSchema) => { | |
| try { | |
| const isSuccess = await handleFormSubmit(data); | |
| if (isSuccess) { | |
| toast.success("Saved"); | |
| } else { | |
| toast.error("Error, saving was unsuccessful."); | |
| } | |
| } catch (error) { | |
| toast.error("An unexpected error occurred."); | |
| } | |
| }; |
| useEffect(() => { | ||
| // If year or month change, recalculate how many days are in the specified month | ||
| if (year && month !== undefined) { | ||
| // Returns the last day of the month, by creating a date with day 0 of the following month. | ||
| const nummberOfDaysInMonth = new Date(year, month + 1, 0).getDate(); | ||
| const daysArray = Array.from( | ||
| { length: nummberOfDaysInMonth }, | ||
| (_, index) => index + 1, | ||
| ); | ||
| setListOfDaysInSelectedMonth(daysArray); | ||
| } | ||
|
|
||
| // Update the date object when year, month or date change | ||
| if (year && month !== undefined && day) { | ||
| let selectedDate: Date; | ||
|
|
||
| if (new Date(year, month, day).getDate() < day) { | ||
| // If user switches to a month in which selected day does not exist | ||
| // ie from 30/1 to feb(only 28 days), then set day to the 1st | ||
| selectedDate = new Date(year, month, 1); | ||
| } else { | ||
| selectedDate = new Date(year, month, day); | ||
| } | ||
| setValue("dateOfBirth", selectedDate); | ||
| } |
There was a problem hiding this comment.
The logic for handling the date of birth selection in SlideTwo is well-implemented, dynamically updating the list of days based on the selected month and year. However, consider abstracting this logic into a custom hook or utility function to improve readability and reusability.
| let isError = await trigger(["professionalOrStudent"]); | ||
|
|
||
| if (isError) { | ||
| const professionalOrStudent = getValues("professionalOrStudent"); | ||
|
|
||
| if (professionalOrStudent === "Working professional") { | ||
| isError = await trigger(["workplace", "jobTitle"]); | ||
|
|
||
| if (isError) { | ||
| router.push(`?slide=${4}`, { scroll: false }); | ||
| } | ||
| } else if (professionalOrStudent === "Current student") { | ||
| isError = await trigger(["levelOfStudy", "course"]); | ||
|
|
||
| if (isError) { | ||
| router.push(`?slide=${4}`, { scroll: false }); | ||
| } | ||
| } else if (professionalOrStudent === "None of the above") { | ||
| router.push(`?slide=${4}`, { scroll: false }); | ||
| } | ||
| } |
There was a problem hiding this comment.
In SlideThree, the logic for navigating to the next slide based on the professionalOrStudent selection is clear and functional. However, the repeated calls to trigger for different fields based on the user's selection could be optimized by grouping related fields into a single trigger call to reduce redundancy.
- isError = await trigger(["workplace", "jobTitle"]);
+ isError = await trigger(professionalOrStudent === "Working professional" ? ["workplace", "jobTitle"] : ["levelOfStudy", "course"]);Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| let isError = await trigger(["professionalOrStudent"]); | |
| if (isError) { | |
| const professionalOrStudent = getValues("professionalOrStudent"); | |
| if (professionalOrStudent === "Working professional") { | |
| isError = await trigger(["workplace", "jobTitle"]); | |
| if (isError) { | |
| router.push(`?slide=${4}`, { scroll: false }); | |
| } | |
| } else if (professionalOrStudent === "Current student") { | |
| isError = await trigger(["levelOfStudy", "course"]); | |
| if (isError) { | |
| router.push(`?slide=${4}`, { scroll: false }); | |
| } | |
| } else if (professionalOrStudent === "None of the above") { | |
| router.push(`?slide=${4}`, { scroll: false }); | |
| } | |
| } | |
| let isError = await trigger(["professionalOrStudent"]); | |
| if (isError) { | |
| const professionalOrStudent = getValues("professionalOrStudent"); | |
| if (professionalOrStudent === "Working professional") { | |
| isError = await trigger(professionalOrStudent === "Working professional" ? ["workplace", "jobTitle"] : ["levelOfStudy", "course"]); | |
| if (isError) { | |
| router.push(`?slide=${4}`, { scroll: false }); | |
| } | |
| } else if (professionalOrStudent === "Current student") { | |
| isError = await trigger(["levelOfStudy", "course"]); | |
| if (isError) { | |
| router.push(`?slide=${4}`, { scroll: false }); | |
| } | |
| } else if (professionalOrStudent === "None of the above") { | |
| router.push(`?slide=${4}`, { scroll: false }); | |
| } | |
| } |
| <div className="flex min-w-[20rem]"> | ||
| <p className="w-1/2">Date of birth: </p>{" "} | ||
| <p className="w-1/2"> | ||
| {" "} | ||
| {dateOfBirth.getDate()} | ||
| {" / "} | ||
| {dateOfBirth.getMonth() + 1} {" / "} | ||
| {dateOfBirth.getFullYear()} | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
In SlideFour, the logic for displaying the date of birth uses getDate, getMonth, and getFullYear directly. This approach does not account for months being zero-indexed. Consider using a date formatting library like date-fns or moment to format the date correctly and improve code readability.
- {dateOfBirth.getDate()} {" / "}
- {dateOfBirth.getMonth() + 1} {" / "}
- {dateOfBirth.getFullYear()}
+ {format(dateOfBirth, "dd / MM / yyyy")}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| <div className="flex min-w-[20rem]"> | |
| <p className="w-1/2">Date of birth: </p>{" "} | |
| <p className="w-1/2"> | |
| {" "} | |
| {dateOfBirth.getDate()} | |
| {" / "} | |
| {dateOfBirth.getMonth() + 1} {" / "} | |
| {dateOfBirth.getFullYear()} | |
| </p> | |
| </div> | |
| <div className="flex min-w-[20rem]"> | |
| <p className="w-1/2">Date of birth: </p>{" "} | |
| <p className="w-1/2"> | |
| {" "} | |
| {format(dateOfBirth, "dd / MM / yyyy")} | |
| </p> | |
| </div> |
John-Paul-Larkin
force-pushed
the
Feature-onboard-developer-form-b2
branch
from
ccc52b4 to
6e652e6
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (7)
- app/alpha/additional-details/_client.tsx (1 hunks)
- app/alpha/additional-details/actions.ts (1 hunks)
- app/alpha/additional-details/page.tsx (1 hunks)
- app/alpha/additional-details/selectOptions.ts (1 hunks)
- prisma/migrations/20240224154056_add_user_data/migration.sql (1 hunks)
- prisma/schema.prisma (8 hunks)
- schema/additionalUserDetails.ts (1 hunks)
Files skipped from review as they are similar to previous changes (6)
- app/alpha/additional-details/_client.tsx
- app/alpha/additional-details/actions.ts
- app/alpha/additional-details/page.tsx
- app/alpha/additional-details/selectOptions.ts
- prisma/schema.prisma
- schema/additionalUserDetails.ts
| ALTER TABLE "User" ADD COLUMN "course" TEXT, | ||
| ADD COLUMN "dateOfBirth" TIMESTAMP(3), | ||
| ADD COLUMN "firstName" TEXT, | ||
| ADD COLUMN "gender" TEXT, | ||
| ADD COLUMN "jobTitle" TEXT, | ||
| ADD COLUMN "levelOfStudy" TEXT, | ||
| ADD COLUMN "professionalOrStudent" TEXT, | ||
| ADD COLUMN "surname" TEXT, | ||
| ADD COLUMN "workplace" TEXT; |
There was a problem hiding this comment.
The migration adds multiple columns to the "User" table, enhancing the user profile with both personal and professional details. Here are a few considerations:
-
Data Types: Ensure that the chosen data types align with the expected data. For example,
TIMESTAMP(3)fordateOfBirthis appropriate as it includes time down to milliseconds, which might be more precise than necessary for a birth date. Consider ifDATEmight be a more suitable choice for storing only the date part. -
Privacy Considerations: Adding personal information such as
dateOfBirth,gender, andsurnameraises privacy and data protection considerations. Ensure that there are policies and features in place for users to control who can view this information or to opt out of providing it. -
Naming Consistency: The naming convention seems consistent, using camelCase for multi-word column names. Ensure this aligns with the rest of the database schema.
-
Potential Missing Columns: Depending on the application's requirements, consider if any additional columns might be necessary for the
Usermodel, such as a column formiddleNameornationality. However, only add these if they are genuinely needed to avoid unnecessary data collection. -
Indexing and Performance: For columns that will be frequently searched or filtered upon, consider adding indexes to improve query performance. However, this should be balanced against the write performance impact.
Consider reviewing the data types for appropriateness, especially for dateOfBirth. Also, ensure privacy considerations are addressed for personal information.
…ure-onboard-developer-form-b2
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- app/alpha/additional-details/_client.tsx (1 hunks)
- app/alpha/additional-details/actions.ts (1 hunks)
- app/alpha/additional-details/page.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- app/alpha/additional-details/_client.tsx
- app/alpha/additional-details/actions.ts
- app/alpha/additional-details/page.tsx
Pull Request details
I was experimenting with prisma migrations on the old branch, so I created a new branch for this PR.
I removed the DeveloperDetails model and added all fields to the User model instead.
npx prisma migrate dev && npx prisma migrate reset
I removed the splash page so the route is now:
/alpha/additional-details
I left the summary page in for now.
Any Breaking changes
NB
I removed @unique from the Membership and RSVP tables. Otherwise, I could not migrate.
I have to go out now, but will try my best to figure this issue later.
Summary by CodeRabbit