Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect user to login page #713

Conversation

John-Paul-Larkin
Copy link
Member

✨ Codu Pull Request 💻

Codu Logo

Pull Request details

Resolve issue which redirected users to an error page, instead of the sign-in page, upon clicking the bookmark button.

@John-Paul-Larkin John-Paul-Larkin requested a review from a team as a code owner February 4, 2024 22:57
Copy link

vercel bot commented Feb 4, 2024

@John-Paul-Larkin is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 6:39pm

Copy link
Contributor

@NiallJoeMaher NiallJoeMaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantic, but could you update this to be:

if (!session) {
  return signIn();
};
if (bookmarked) {
  return bookmarkPost(id, false);
}
bookmarkPost(id);

Having the logical closures is a little easier to read.

Copy link
Contributor

@NiallJoeMaher NiallJoeMaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and quick! Thanks! 🌮

@NiallJoeMaher NiallJoeMaher merged commit b5ccc37 into codu-code:develop Feb 5, 2024
2 of 4 checks passed
@John-Paul-Larkin John-Paul-Larkin deleted the 712-bug-clicking-bookmark-leads-to-error-page branch March 27, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants