-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Tests for username change on /settings page. #1203
base: develop
Are you sure you want to change the base?
Changes from 2 commits
67c5c4f
e6883a5
87038df
01c19f8
071f93a
f9140cf
fcd1dbb
2b779b6
c6949d0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import test from "@playwright/test"; | ||
import { test, expect } from "@playwright/test"; | ||
import { loggedInAsUserOne } from "./utils"; | ||
|
||
test.describe("Unauthenticated setttings Page", () => { | ||
|
@@ -10,6 +10,32 @@ test.describe("Authenticated settings Page", () => { | |
test.beforeEach(async ({ page }) => { | ||
await loggedInAsUserOne(page); | ||
}); | ||
// | ||
// Replace with tests for authenticated users | ||
|
||
// Test for changing username | ||
test('Username input field', async ({ page }) => { | ||
await page.goto('http://localhost:3000/settings', { timeout: 30000 }); | ||
|
||
// Wait for the username input field to be visible | ||
await page.locator('input[id="username"]').waitFor(); | ||
|
||
// Test that the input field is visible and has the correct attributes | ||
const inputField = page.locator('input[id="username"]'); | ||
await expect(inputField).toBeVisible(); | ||
await expect(inputField).toHaveAttribute('type', 'text'); | ||
await expect(inputField).toHaveAttribute('autocomplete', 'username'); | ||
|
||
// Test that the error message appears when the input field is invalid | ||
await inputField.fill('45&p^x#@!96%*()'); | ||
await page.locator('button[type="submit"]').click(); | ||
const errorMessage = page.locator('p:text-is("Username can only contain alphanumerics and dashes.")') | ||
await expect(errorMessage).toBeVisible(); | ||
await expect(errorMessage).toHaveText('Username can only contain alphanumerics and dashes.'); | ||
// Reset the form | ||
petercr marked this conversation as resolved.
Show resolved
Hide resolved
|
||
await page.locator('button:has-text("Reset")').click(); | ||
|
||
// Test that the input field can be filled with a valid value and saves it | ||
await inputField.fill('codu-rules'); | ||
await page.locator('button[type="submit"]').click(); | ||
await expect(inputField).toHaveValue('codu-rules'); | ||
}); | ||
petercr marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will this wait for the username change to take effect? If you fill in the new username and then click submit. Will this test see the new username you have entered as the value of the input and complete straight away? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I mean the tests pass for it. But it could be just catching the still filled in form from before the reset. Would you like me to change it to a page refresh instead? Or would you like some kind of timeOut in-between the state change and checking for the change to persist? I would be happy to add either one ππ» There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I am not sure is there a loading indicator for these types of change? It would be nice to see
|
||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π οΈ Refactor suggestion
Improve test configuration and navigation
Consider these improvements:
Add this to your playwright.config.ts:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.