-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: init e2e workflow setup #1086
Conversation
WalkthroughThe Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The tests will start passing once this PR merged and rebased into the e2e workflow branched |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
playwright.config.ts (1)
Line range hint
1-80
: Consider additional e2e setup requirements
The PR objectives mention adding secrets for the database and GitHub application setup. Ensure these secrets are properly configured in the appropriate place (e.g., GitHub Secrets, environment variables) for the e2e workflow to function correctly.
The
baseURL
is currently commented out in the configuration. Consider uncommenting and setting it to the appropriate URL for your e2e tests:use: { /* Base URL to use in actions like `await page.goto('/')`. */ baseURL: 'http://127.0.0.1:3000', // ... },This can help simplify your test scripts by allowing you to use relative paths in your
page.goto()
calls.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (2)
.github/workflows/e2e-tests.yml
is excluded by!**/*.yml
package.json
is excluded by!**/*.json
📒 Files selected for processing (1)
- playwright.config.ts (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
playwright.config.ts (1)
74-74
: LGTM: Updated command for e2e testing environmentThe change from
"npm run dev"
to"npm run dev:e2e"
aligns with the PR objective of setting up an e2e testing workflow. This modification ensures that the correct environment is used for end-to-end testing.To ensure this change is properly integrated, let's verify the existence and content of the
dev:e2e
script:✅ Verification successful
Verified:
dev:e2e
script exists and is correctly configuredThe
dev:e2e
script is present inpackage.json
with the expected configuration. This ensures that the Playwright setup inplaywright.config.ts
uses the appropriate environment for end-to-end testing.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence and content of the dev:e2e script in package.json # Test: Check if the dev:e2e script exists in package.json jq '.scripts["dev:e2e"]' package.json # If the script exists, its content will be displayed. If it doesn't exist, null will be returned.Length of output: 58
@NiallJoeMaher @John-Paul-Larkin Also we need to create github oauth client for testing github auth flows |
@pkspyder007 - Do you think we should use an e2e database url or just give it a database URL it can use instead (rather than having a separate one). Eg. if we used |
@NiallJoeMaher The current setup uses |
Also wanna add that running a docker image will utilise more resource and cost us more and lead to increased the CI times. |
@NiallJoeMaher have a look whenever you get time few action items
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
✨ Codu Pull Request 💻
Fixes #(issue)
Pull Request details
Any Breaking changes
Associated Screenshots