Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV2-4253 allow null response for Workspace request #690

Merged
merged 2 commits into from
Nov 20, 2023
Merged

DEV2-4253 allow null response for Workspace request #690

merged 2 commits into from
Nov 20, 2023

Conversation

yonip23
Copy link
Contributor

@yonip23 yonip23 commented Nov 20, 2023

No description provided.

@yonip23 yonip23 requested a review from a team as a code owner November 20, 2023 09:23
dimacodota
dimacodota approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@dimacodota dimacodota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amircodota
Copy link
Contributor

amircodota commented Nov 20, 2023 •
edited
Loading

Do not think it will fix it

I think you are running into this

tabnine-intellij/Common/src/main/java/com/tabnineCommon/binary/ParsedBinaryIO.java

Line 30 in ac9488e

() -> new TabNineInvalidResponseException("Binary returned null as a response"));

@yonip23
Copy link
Contributor Author

yonip23 commented Nov 20, 2023

@amircodota it catches it and then goes to this line:

tabnine-intellij/Common/src/main/java/com/tabnineCommon/binary/BinaryProcessRequesterImpl.java

Line 73 in ac9488e

if (request.shouldBeAllowed(exception)) {

i verified with debug breakpoint

@yonip23 yonip23 merged commit ffd791a into master Nov 20, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimacodota dimacodota dimacodota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yonip23 @amircodota @dimacodota