Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV2-4218 add support for multi-repo workspace #685

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

yonip23
Copy link
Contributor

@yonip23 yonip23 commented Nov 12, 2023

I ran on IJ CE 2020.2 (the sandbox, by running runIde) and on IJ CE 2023.5 (local installation) to make sure there were no EDT/read violations.

one concern i have, is that the "Workspace" API returns null, and we don't count null responses as success.. maybe I should return "Done" from the binary or something?

@yonip23 yonip23 requested a review from a team as a code owner November 12, 2023 13:43
Copy link
Contributor

@amircodota amircodota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

Copy link
Contributor

@amircodota amircodota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonip23 yonip23 marked this pull request as draft November 12, 2023 14:25
@yonip23
Copy link
Contributor Author

yonip23 commented Nov 12, 2023

waiting for the binary to be released before merging this

@yonip23 yonip23 changed the title DEV2-4218 add update workspace service DEV2-4218 add support for multi-repo workspace Nov 14, 2023
@yonip23 yonip23 marked this pull request as ready for review November 14, 2023 21:44
@yonip23 yonip23 requested a review from amircodota November 14, 2023 21:45
Copy link
Contributor

@amircodota amircodota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonip23 yonip23 merged commit d06a855 into master Nov 15, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants