-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV2-4218 add support for multi-repo workspace #685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments
Common/src/main/java/com/tabnineCommon/chat/commandHandlers/InitHandler.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
waiting for the binary to be released before merging this |
…-4218-send-workspace-updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I ran on IJ CE 2020.2 (the sandbox, by running
runIde
) and on IJ CE 2023.5 (local installation) to make sure there were no EDT/read violations.one concern i have, is that the
"Workspace"
API returns null, and we don't count null responses as success.. maybe I should return "Done" from the binary or something?