DEV2-3818 support insecure mode #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirbilu
force-pushed
the
add-tls-config
branch
from
638c92d to
5a69643
Compare
| @@ -24,6 +26,9 @@ | |||
| import org.jetbrains.annotations.Nullable; | |||
|
|
|||
| public class BinaryRun { | |||
|
|
|||
| static final SemVer TLS_CONFIG_MIN_SUPPORTED_VERSION = SemVer.parseFromText("4.22.0"); | |||
There was a problem hiding this comment.
why? what is this? backward compatibility?
| @@ -57,15 +57,14 @@ public String fetchBinary() throws NoValidBinaryToRunException { | |||
| preferredBetaVersion.get().getVersion())); | |||
|
|
|||
| if (!isBadVersion(preferredBetaVersion.get())) { | |||
| return preferredBetaVersion.get().getVersionFullPath(); | |||
| return preferredBetaVersion.get(); | |||
There was a problem hiding this comment.
can't find relation to this in the code, will beta still work?
| @@ -74,6 +74,7 @@ class AppSettingsConfigurable : Configurable { | |||
| settings.cloud2Url = settingsComponent!!.cloud2Url | |||
| settings.useIJProxySettings = settingsComponent!!.useIJProxySettings | |||
| settings.autoPluginUpdates = settingsComponent!!.autoPluginUpdates | |||
| settings.ignoreCertificateErrors = settingsComponent!!.ignoreCertificateErrors | |||
There was a problem hiding this comment.
what does !! mean in kotlin?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.