DEV2-4200: Fix cached inconsistent value (#702)

* Change the status bar fields to be volatile to enforce that it is being read with the most updated value. * Change the status bar fields to be volatile to enforce that it is being read with the most updated value. * Formatting
codota · Dec 6, 2023 · 0bd9699 · 0bd9699
1 parent b9edced
commit 0bd9699
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/Tabnine/src/main/java/com/tabnine/statusBar/TabnineStatusBarWidget.java b/Tabnine/src/main/java/com/tabnine/statusBar/TabnineStatusBarWidget.java
@@ -31,18 +31,19 @@
 public class TabnineStatusBarWidget extends EditorBasedWidget
     implements StatusBarWidget, StatusBarWidget.MultipleTextValuesPresentation {
   private static final String EMPTY_SYMBOL = "\u0000";
-  private boolean isLimited = false;
+  private volatile boolean isLimited = false;
 
-  private Boolean isLoggedIn = getLastBinaryState().map(StateResponse::isLoggedIn).orElse(null);
+  private volatile Boolean isLoggedIn =
+      getLastBinaryState().map(StateResponse::isLoggedIn).orElse(null);
 
-  private ServiceLevel serviceLevel =
+  private volatile ServiceLevel serviceLevel =
       getLastBinaryState().map(StateResponse::getServiceLevel).orElse(null);
-  private CloudConnectionHealthStatus cloudConnectionHealthStatus =
+  private volatile CloudConnectionHealthStatus cloudConnectionHealthStatus =
       getLastBinaryState()
           .map(StateResponse::getCloudConnectionHealthStatus)
           .orElse(CloudConnectionHealthStatus.Ok);
 
-  @Nullable private Boolean isForcedRegistration = null;
+  @Nullable private volatile Boolean isForcedRegistration = null;
 
   public TabnineStatusBarWidget(@NotNull Project project) {
     super(project);

diff --git a/...fHosted/src/main/java/com/tabnineSelfHosted/statusBar/TabnineSelfHostedStatusBarWidget.kt b/...fHosted/src/main/java/com/tabnineSelfHosted/statusBar/TabnineSelfHostedStatusBarWidget.kt
@@ -23,7 +23,9 @@ class TabnineSelfHostedStatusBarWidget(project: Project) :
     EditorBasedWidget(project),
     StatusBarWidget,
     MultipleTextValuesPresentation {
+    @Volatile
     private var userInfoResponse = UserInfoStateSingleton.instance.get()
+    @Volatile
     private var connectionHealthStatus =
         BinaryStateSingleton.instance.get()?.cloudConnectionHealthStatus