Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User aliases does not work #505 #514

Closed
wants to merge 2 commits into from
Closed

User aliases does not work #505 #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a990cf
Closes #505
overkam Jan 14, 2019
ea2f35d
Closes #505
overkam Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion www/application/classes/Controller/Articles/Modify.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public function action_save()
return;
}

$uri = Arr::get($_POST, 'uri');
$uri = strtolower(Arr::get($_POST, 'uri'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а если ::get вернёт не строку?

$alias = Model_Aliases::generateUri($uri);

if ($article_id) {
Expand Down
1 change: 1 addition & 0 deletions www/application/classes/Controller/Users/Index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ public function action_settings()
$name = Arr::get($_POST, 'name');
$bio = Arr::get($_POST, 'bio');
$alias = Arr::get($_POST, 'alias');
$alias = strtolower(Arr::get($_POST, 'alias'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

выглядит, как дублирование кода


$instagram_uri = $this->methods->parseUri(Arr::get($_POST, 'instagram_uri'));
$vk_uri = $this->methods->parseUri(Arr::get($_POST, 'vk_uri'));
Expand Down