Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove deprecated cid function #1111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: Remove deprecated cid function #1111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c8528d
Remove deprecated function
2-towns Feb 12, 2025
3e20096
Merge branch 'master' into chore/clean-treecid-deprecation
dryajov Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions codex/manifest/manifest.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,6 @@ func verify*(self: Manifest): ?!void =

return success()

func cid*(self: Manifest): ?!Cid {.deprecated: "use treeCid instead".} =
self.treeCid.success

func `==`*(a, b: Manifest): bool =
(a.treeCid == b.treeCid) and (a.datasetSize == b.datasetSize) and
(a.blockSize == b.blockSize) and (a.version == b.version) and (a.hcodec == b.hcodec) and
Expand Down
2 changes: 1 addition & 1 deletion codex/streams/storestream.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ method readOnce*(
raise newLPStreamReadError(error)

trace "Reading bytes from store stream",
manifestCid = self.manifest.cid.get(),
manifestCid = self.manifest.treeCid,
numBlocks = self.manifest.blocksCount,
blockNum,
blkCid = blk.cid,
Expand Down
4 changes: 2 additions & 2 deletions tests/codex/blockexchange/discovery/testdiscovery.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@ asyncchecksuite "Block Advertising and Discovery":

await engine.stop()

test "Should advertise both manifests and trees":
test "Should advertise trees":
let
cids = @[manifest.cid.tryGet, manifest.treeCid]
cids = @[manifest.treeCid]
advertised = initTable.collect:
for cid in cids:
{cid: newFuture[void]()}
Expand Down
Loading