Added the ability to get TOTP tokens #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qtc-de
reviewed
Mar 16, 2024
| @@ -595,6 +595,35 @@ def get_secret(self) -> str: | |||
| self.item.load_secret_sync() | |||
| return self.item.get_secret().get_text() | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please remove superfluous newline :)
qtc-de
reviewed
Mar 16, 2024
|
|
||
| Returns: | ||
| TOTP token | ||
|
|
There was a problem hiding this comment.
Please remove superfluous newline :)
qtc-de
reviewed
Mar 16, 2024
| if otp_value[0] == "secret": | ||
| return pyotp.TOTP(otp_value[1]).now() | ||
|
|
||
|
|
There was a problem hiding this comment.
Please remove superfluous newline :)
qtc-de
reviewed
Mar 16, 2024
| return | ||
|
|
||
| if "totp" in self.item.get_attributes().get('otp'): | ||
| otp_value = self.item.get_attributes().get('otp').split("?")[1].split("&")[0].split("=") |
There was a problem hiding this comment.
What is the actual format here? Is this always the same? Can you provide a example string?
|
It is really unfortunate that one cannot obtain the current OTP via KeePass directly and has to use an additional library. However, I agree that this is probably the best workaround 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I have fixed the quick 'hack' and now added the ability to Opt-In to get a TOTP token.
Furthermore, it was not possible to get the new token with get_attributes() after the time has run out.
I also tried reloading the whole database which did not seem to work.
As such, I had to include a library which generates the TOTP when pressing Ctrl + t.
The feature can be activated by setting view_totp = True.
The following library is needed to generate the TOTP:
pyotpIt is to note, that the library is only needed when copying a TOTP token and would not be needed if deactivated. (Check source code)
Cheers