feat: counter system #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaf-upper
reviewed
Feb 15, 2020
| <textarea cols="15" rows="1" class="outputNum" readonly>0</textarea> | ||
| <br> | ||
| <br> | ||
| <input type="button" value="+" class="increaseButton"> |
There was a problem hiding this comment.
html태그속성들을 전부 id값이 아닌 class로 한 이유가 궁금합니다!
|
|
||
|
|
||
| function decreaseButtonAction(e){ | ||
| var temp = textarea_outputNum.textContent; |
There was a problem hiding this comment.
변수명을 temp, temp2가 아닌 좀 더 의미가 분명한 변수명을 써주셨으면 좋겠습니다
| @@ -0,0 +1,58 @@ | |||
| const textarea_outputNum = document.querySelector("textarea.outputNum"); | |||
There was a problem hiding this comment.
querySelector는 어떤 방식으로 dom에 객체를 요청하는지 궁금합니다!
Tetramad
reviewed
Feb 16, 2020
| <meta charset = "utf-8"> | ||
| </head> | ||
| <body> | ||
| <!-- <p>0</p> --> |
| <input type="button" value="-" class="decreaseButton"> | ||
| <br> | ||
| <br> | ||
| <p style="display:inline">step</p > |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.