Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump psycopg2 to 2.9.10 & rpds-py to 0.22.3 #767

Merged

Conversation

JanWen
Copy link

@JanWen JanWen commented Jan 28, 2025

What GitHub issue does this PR apply to?

Resolves #766

What changed and why?

Update psycopg2 and rpds-py to fix docker compose build.

I also ran into the described issue when trying to run docker compose build locally. This was possible to fix by bumping psycopg2 to 2.9.10 and its possible it also fixes the build on Github.
However, I also ran into the following error, related to installing rpds-py when running docker compose:

#0 8.755 Collecting rpds-py==0.10.6 (from -r requirements.txt (line 29))
#0 8.797   Downloading rpds_py-0.10.6.tar.gz (16 kB)
#0 8.810   Installing build dependencies: started
#0 10.74   Installing build dependencies: finished with status 'done'
#0 10.74   Getting requirements to build wheel: started
#0 10.79   Getting requirements to build wheel: finished with status 'done'
#0 10.80   Preparing metadata (pyproject.toml): started
#0 10.85   Preparing metadata (pyproject.toml): finished with status 'error'
#0 10.85   error: subprocess-exited-with-error
#0 10.85
#0 10.85   × Preparing metadata (pyproject.toml) did not run successfully.
#0 10.85   │ exit code: 1
#0 10.85   ╰─> [6 lines of output]
#0 10.85
#0 10.85       Cargo, the Rust package manager, is not installed or is not on PATH.
#0 10.85       This package requires Rust and Cargo to compile extensions. Install it through
#0 10.85       the system's package manager or via https://rustup.rs/
#0 10.85
#0 10.85       Checking for Rust toolchain....
#0 10.85       [end of output]
#0 10.85
#0 10.85   note: This error originates from a subprocess, and is likely not a problem with pip.

This also seems fixed after updating rpds-py to the lastet version.

Checklist

  • I claimed any associated issue(s) and they are not someone else's
  • I have looked at documentation to ensure I made any revisions correctly
  • I tested my changes locally to ensure they work
  • For language files, I have validated the edited files are valid JSON and data shows up correctly
  • For website code edits, I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

@JanWen JanWen force-pushed the issue-766-fix-docker-compose branch from 50f9275 to f38a062 Compare January 28, 2025 22:45
@geekygirlsarah
Copy link
Member

This does seem to make the build happy! I'll test on Heroku quickly too

@geekygirlsarah geekygirlsarah temporarily deployed to codethesaurus-test-pr-767 January 29, 2025 17:17 Inactive
@geekygirlsarah geekygirlsarah temporarily deployed to codethesaurus-test-pr-767 January 29, 2025 17:26 Inactive
@geekygirlsarah
Copy link
Member

It does seem to be happy on the staging site too! I'd say if you're good you can take it out of draft PR status

@JanWen JanWen marked this pull request as ready for review January 29, 2025 17:38
@JanWen
Copy link
Author

JanWen commented Jan 29, 2025

Thank you for the quick review! I've cleaned up the description and opened the PR for review.

Copy link
Member

@geekygirlsarah geekygirlsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! And being a first-time contributor! I just haven't had the time to sit down and do it for a while. I appreciate it!

@geekygirlsarah geekygirlsarah merged commit c227583 into codethesaurus:main Jan 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] docker compose build check fails but only on GitHub
2 participants