Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE][Team17] Cooper,Robin 2차 PR 보냅니다 #61

Open
wants to merge 60 commits into
base: team17-final
Choose a base branch
from
+1,716 −0
Open

[BE][Team17] Cooper,Robin 2차 PR 보냅니다 #61

Changes from 2 commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
3642f9b
Chore : 백엔드 프로젝트 파일을 생성하라.
pbg0205 Apr 20, 2021
0b2600b
Feat: 스프링 데이터 jdbc으로 셋팅하라
malaheaven Apr 21, 2021
7fc73cc
Merge pull request #10 from swing-park/feature-setup-jdbc
pbg0205 Apr 21, 2021
41d119b
Feat: domain을 생성해라
malaheaven Apr 21, 2021
d9290c6
Merge pull request #11 from swing-park/feature-create-domain
pbg0205 Apr 21, 2021
5849e54
Feat: repository를 생성해라
malaheaven Apr 21, 2021
64d0596
Merge pull request #12 from swing-park/feature-create-repository
pbg0205 Apr 21, 2021
16d4c02
Fix : DB 스키마 변경하라
malaheaven Apr 22, 2021
fe0e43c
Merge pull request #17 from swing-park/fix-db-schema
pbg0205 Apr 22, 2021
b970e66
Feat: controller를 만들어라
malaheaven Apr 22, 2021
8c2ca83
Merge pull request #18 from swing-park/feature-create-controller
pbg0205 Apr 22, 2021
5f05a54
style : 변수명 오탈자를 수정하라.
pbg0205 Apr 22, 2021
a34d29c
feat : finAll 메서드를 추가하라.
pbg0205 Apr 22, 2021
21ef877
feat : domain과 dto에 getter를 추가해라.
pbg0205 Apr 22, 2021
5d7243b
feat : 베스트목록들을 반환하는 메서드를 작성하라.
pbg0205 Apr 22, 2021
e842d9a
feat : 베스트 카테고리 목록을 조회하라.
pbg0205 Apr 23, 2021
f75f0b9
feat : service layer를 추가하라.
pbg0205 Apr 23, 2021
92a2627
Merge pull request #21 from swing-park/feature-create-get-method
malaheaven Apr 23, 2021
4f09ac7
style : ItemDto item 변수명을 변경하라.
pbg0205 Apr 23, 2021
5dcf127
Merge pull request #22 from swing-park/feature-create-get-method
malaheaven Apr 23, 2021
7b874c4
Feat: DishCategory 조회 기능을 구현해라
malaheaven Apr 23, 2021
8cf8d8c
Merge pull request #24 from swing-park/feature-create-dishcategory
pbg0205 Apr 23, 2021
991103c
refactor : 불필요한 의존성을 제거하라.
pbg0205 Apr 25, 2021
4d1f50a
feat : BestCategory의 불필요한 의존성을 제거하라.
pbg0205 Apr 25, 2021
84c3609
refactor : imageRepository 의존성을주입하자.
pbg0205 Apr 25, 2021
7ebac27
refactor : dto의 nPrice, sPrice 변수명을 변경하라.
pbg0205 Apr 25, 2021
23d2ecf
refactor : itemDto 변수명에 final을 선언하라.
pbg0205 Apr 25, 2021
bab8d75
feat : 상세정보를 조회하는 기능을 구현하라.
pbg0205 Apr 26, 2021
e7d652d
Merge pull request #29 from swing-park/feature-create-detail
malaheaven Apr 26, 2021
72346c5
refactor : API관련 내용을 수정하라.
pbg0205 Apr 27, 2021
b0daa2e
Merge pull request #36 from swing-park/refactor-response-json-api
malaheaven Apr 27, 2021
5bed534
feat : CORS 기능을 구현하라.
pbg0205 Apr 27, 2021
8a1afdc
Merge pull request #37 from swing-park/feature-setup-cors
malaheaven Apr 27, 2021
8591818
style : URL 추가 / 제거
pbg0205 Apr 27, 2021
b4badb8
Merge pull request #39 from swing-park/style-url-path
malaheaven Apr 27, 2021
004c536
fix : 오탈자 수정 및 URL 추가 수정
pbg0205 Apr 27, 2021
6edbbcf
Merge pull request #41 from swing-park/style-url-path
malaheaven Apr 27, 2021
1c51b98
style : 중복된 URL을 제거하라.
pbg0205 Apr 27, 2021
ac31a2f
Merge pull request #43 from swing-park/style-url-path
pbg0205 Apr 27, 2021
621d6c4
Fix: dish url
malaheaven Apr 27, 2021
ab9efe8
Merge pull request #45 from swing-park/fix-dish-url
malaheaven Apr 27, 2021
ad07c85
feat : 주문 기능을 위한 OrderDto 생성
pbg0205 Apr 27, 2021
9de9048
feat : OrderController 생성
pbg0205 Apr 27, 2021
15d6ab0
feat : Item entity에 재고 반영 기능 추가
pbg0205 Apr 27, 2021
528fe7d
feat : 재고 반영을 위한 OrderService를 생성하라.
pbg0205 Apr 27, 2021
955b7c7
Merge pull request #50 from swing-park/feature-order-test
malaheaven Apr 28, 2021
c0b10b5
feat : ItemDetailDto deliveryInfo 변수명을 추가하라.
pbg0205 Apr 28, 2021
c57bc46
style : dummy data를 수정하라.
pbg0205 Apr 28, 2021
ef89ce5
feat : 추천 목록을 10개를 임의로 반환하라.
pbg0205 Apr 28, 2021
920ec75
Merge pull request #51 from swing-park/refactor-FE-feedback
malaheaven Apr 28, 2021
c37a453
refactor : RequestBody 형태로 데이터를 전달받아라.
pbg0205 Apr 28, 2021
7032c0c
Merge pull request #55 from swing-park/feature-order
malaheaven Apr 28, 2021
9f364c8
Feat: 커스텀 이셉션 핸들러를 이용하여 예외를 처리
malaheaven Apr 28, 2021
b50f10b
Merge pull request #61 from swing-park/feature-exception-handler
pbg0205 Apr 28, 2021
90658f1
feat : CORS 설정에 PUT METHOD를 추가하라.
pbg0205 Apr 29, 2021
362f0fb
Merge pull request #62 from swing-park/feat-cors-put
malaheaven Apr 29, 2021
ae71da2
chore : jackson databind dependency를 추가하라.
pbg0205 Apr 29, 2021
8c3d66e
Merge pull request #66 from swing-park/chore-jackson-core
malaheaven Apr 29, 2021
65facbd
style : 코드에 개행과 정렬을 맞춰라.
pbg0205 Apr 30, 2021
67453c1
Merge pull request #73 from swing-park/style-code
malaheaven Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...am17/sidedish/dto/RecommandedItemDto.java → ...am17/sidedish/dto/RecommendedItemDto.java
View file
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ public RecommandedItemDto (Item entity, Image image) {
this.image = image.getUrl();

this.price = entity.getNormalPrice().intValue();
this.detailUrl = URL + URL + "/dish" + "/detail" + "/" + itemId;
this.detailUrl = URL + "/dish" + "/detail" + "/" + itemId;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 물론 FE와 협의를 하셨겠지만 호스트 네임은 FE에서 FE의 로직으로 결정되게 하는 편이 항상 안전하긴 합니다.
워낙 변수가 많은 부분이기도 해서...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇군요.. 이번에 리뷰를 통해 배웠습니다 이 부분이 고민이 들었었는데, 리뷰 감사합니다

}

public static String getURL() {