-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Team10 - 쑤, Zeke] Issue, Label, Milestone View 구현 #16
Merged
Merged
Changes from all commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
ffa6744
chore: 🔧 프로젝트 생성
zekexros 8685ae5
chore: 🔧 .DS_Store 삭제
zekexros 28a63d1
chore: 🔧 SwiftLint 라이브러리 추가
zekexros 1198271
chore: 🔧 SnapKit 라이브러리 추가
zekexros b36ed9d
chore:🔧 gitignore의 *.xcodeproj 주석처리
zekexros 0519fd7
feat: ✨add endpoint model
lenaios ccaf439
feat: ✨ add networkable protocol
lenaios a9cd883
chore: 🔧 clean up directory
lenaios 3c7b011
chore: 🔧 change build target
lenaios 46b3482
Merge pull request #13 from swing-park/iOS/feature/4/network
lenaios 0021a44
chore: 🔧 delete unnecessary comment
lenaios ad6a581
feat: ✨ add AuthManager (#15)
lenaios bb6bcaf
feat: ✨ Implement ID,Password TextField View
zekexros de0c7cb
feat: ✨ Add AppleLoginButton (#14)
zekexros dd3ea94
feat: ✨Add IDPasswordTextField (#14)
zekexros 716b755
feat: ✨Add GitHubLoginButton (#14)
zekexros 737cba4
feat: ✨Add LoginView (#14)
zekexros 45f03d4
chore: 🔧 Add GitHub, Apple logo images
zekexros 6e21dae
chore: 🔧 apply to mainstoryboard
zekexros d56413a
Merge pull request #16 from swing-park/iOS/feature/14/LoginView
zekexros c978b1e
Merge remote-tracking branch 'refs/remotes/origin/dev/iOS'
lenaios 41d8822
chore: 🔧 update package info
lenaios c99c04d
feat: ✨ embed in tab bar controller
lenaios 949208e
Merge pull request #19 from swing-park/iOS/feature/#18/tabBarController
lenaios 8e667fd
feat: ✨ LabelTableViewCell 구현 (#20)
zekexros 2f1fd6c
feat: ✨ LabelTableHeaderView 구현 (#20)
zekexros 102c123
feat: ✨ extend UIColor to use HexColor (#20)
zekexros bdbb2ad
feat: ✨ AddButton 구현 (#20)
zekexros dc72fad
chore: 🔧 LabelViewController 추가(#20)
zekexros a755477
chore: 🔧 foldering view files
zekexros fdb5124
chore: 🔧 switch AddButton type UIStackView to UIView(#20)
zekexros 9c96996
chore: 🔧 Add line in LabelTableHeaderView(#20)
zekexros 52c92bd
chore: 🔧 switch UIColor extension init to static func (#20)
zekexros 84643a4
feat: ✨ padding을 가지는 custom label 구현 (#20)
zekexros 45d1f82
chore: 🔧 paddingLabel 적용 및 identifier 추가 (#20)
zekexros 45752de
feat: ✨TableView 생성 및 fake data를 이용한 구현 (#20)
zekexros cde0630
Merge pull request #26 from swing-park/iOS/feature/#20/LabelTabView
zekexros 64ddb7e
feat: ✨ add milestone view
lenaios 5ee9a40
Merge branch 'iOS/feature/#21/milestone'
lenaios a5d407c
chore: :hammer: embed in navigation controller to milestone view cont…
lenaios 6b0e78c
chore: :wrench: clean up directory
lenaios 0760f2a
chore: :wrench: fix typo
lenaios 5240edd
feat: add IssueFilterViewController (#28)
lenaios 60478a3
feat: :sparkles: add cell's accessoryType
lenaios 35b417e
Merge pull request #29 from swing-park/iOS/feature/issueFilter
lenaios d8145e3
feat: ✨ IssueTableView Cell 구현 (#27)
zekexros 5c87910
feat: ✨ IssueTableFooterView 구현 (#27)
zekexros 6ec6a5d
feat: ✨ AddIssueButton 구현 (#27)
zekexros 23f2261
feat: ✨ FilterBarButton 구현 (#27)
zekexros de79d82
feat: ✨ CancelBarButton 구현 (#27)
zekexros 4d41875
feat: ✨ SelectBarButton 구현 (#27)
zekexros d07f51c
feat: ✨ MilestoneView 구현 (#27)
zekexros 315f4db
feat: ✨ IssueToolbar 구현 (#27)
zekexros e6a5acb
feat: ✨ IssueListViewController 구현
zekexros 9ef6177
feat: :sparkles: add new issue view (#30)
lenaios 6b4a462
feat: add markdown preview (#30)
lenaios f0afc7a
feat: add issue detail view
lenaios 67700d7
Merge pull request #32 from swing-park/iOS/feature/newIssue
lenaios a13069d
feat: add custom table view cell for issue detail (#34)
lenaios 495ec50
chore: 🔧 AddIssueButton 수정
zekexros 57faa75
chore: 🔧 Change Issue check way removeFromSuperView to Hidden
zekexros 4f30d3b
chore: 🔧 LabelViewController의 HeaderView 수정
zekexros fb12620
feat: add scroll function (#34)
lenaios 41e5c34
feat: post comment (#34)
lenaios 6c620f7
Merge pull request #35 from swing-park/iOS/feature/issueDetail
lenaios 4330706
chore: 🔧 LabelTableHeaderView 제거
zekexros 5d01a50
chore: update milestone detail
lenaios b4202b1
feat: ✨ LabelsCollectionView 구현
zekexros 75a9c71
feat: ✨ LabelsCollectionView Cell구현
zekexros 46e4494
chore: 🔧 IssueTableViewCell 수정
zekexros 41595e6
chore: update add view controller to use table view
lenaios a433b92
feat: add modal view for issue detail view
lenaios ae818e3
Merge branch 'iOS/feature/#27/IssueList'
zekexros 6722591
Merge branch 'iOS/feature/detail'
lenaios a2aa760
chore: rename vector image
lenaios 23cd411
chore: add login storyboard to avoid warning
lenaios 62798f8
feat: add button action to show new issue view
lenaios 578867f
feat: add segue to issue detail view
lenaios 80c8584
Merge pull request #37 from swing-park/iOS/feature/complement
lenaios a1f7384
chore: 🔧 이미지파일변경
zekexros d5f4951
feat: ✨ IssueList DTO 구현 (#38)
zekexros b9b4e35
feat: ✨ IssueDetail DTO 구현 (#38)
zekexros 0d3a61f
feat: ✨ NewIssue DTO 구현
zekexros 70dc46e
chore: 🔧 파일 생성 및 수정
zekexros b3a066b
feat: add dto model (#38)
lenaios cb11a04
Merge pull request #41 from swing-park/iOS/feature/#38/UserDTO
lenaios 39a18d7
chore: change directory
lenaios 5a83227
Delete .DS_Store
lenaios 558db1f
chore: add entry point to login storyboard
lenaios ec5bb6a
chore: add custom textField to avoid lazy view
lenaios d21b2a7
chore: remove check mode func
lenaios 0e84fb7
chore: change fatalError to assert
lenaios eb82907
chore: implement required init
lenaios 57c9ae4
chore: modify autolayout for table view
lenaios 3af47e8
chore: switch method name set to setup
lenaios File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,122 @@ | ||
``` | ||
# Created by https://www.gitignore.io/api/xcode,swift,cocoapods | ||
# Edit at https://www.gitignore.io/?templates=xcode,swift,cocoapods | ||
|
||
### CocoaPods ### | ||
## CocoaPods GitIgnore Template | ||
|
||
# CocoaPods - Only use to conserve bandwidth / Save time on Pushing | ||
# - Also handy if you have a large number of dependant pods | ||
# - AS PER https://guides.cocoapods.org/using/using-cocoapods.html NEVER IGNORE THE LOCK FILE | ||
Pods/ | ||
|
||
### Swift ### | ||
# Xcode | ||
# | ||
# gitignore contributors: remember to update Global/Xcode.gitignore, Objective-C.gitignore & Swift.gitignore | ||
|
||
## Build generated | ||
build/ | ||
DerivedData/ | ||
|
||
## Various settings | ||
*.pbxuser | ||
!default.pbxuser | ||
*.mode1v3 | ||
!default.mode1v3 | ||
*.mode2v3 | ||
!default.mode2v3 | ||
*.perspectivev3 | ||
!default.perspectivev3 | ||
xcuserdata/ | ||
|
||
## Other | ||
*.moved-aside | ||
*.xccheckout | ||
*.xcscmblueprint | ||
|
||
## Obj-C/Swift specific | ||
*.hmap | ||
*.ipa | ||
*.dSYM.zip | ||
*.dSYM | ||
|
||
## Playgrounds | ||
timeline.xctimeline | ||
playground.xcworkspace | ||
|
||
# Swift Package Manager | ||
# Add this line if you want to avoid checking in source code from Swift Package Manager dependencies. | ||
# Packages/ | ||
# Package.pins | ||
# Package.resolved | ||
.build/ | ||
# Add this line if you want to avoid checking in Xcode SPM integration. | ||
# .swiftpm/xcode | ||
|
||
# CocoaPods | ||
# We recommend against adding the Pods directory to your .gitignore. However | ||
# you should judge for yourself, the pros and cons are mentioned at: | ||
# https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control | ||
# Pods/ | ||
# Add this line if you want to avoid checking in source code from the Xcode workspace | ||
# *.xcworkspace | ||
|
||
# Carthage | ||
# Add this line if you want to avoid checking in source code from Carthage dependencies. | ||
# Carthage/Checkouts | ||
|
||
Carthage/Build | ||
|
||
# Accio dependency management | ||
Dependencies/ | ||
.accio/ | ||
|
||
### SwiftPackageManager ### | ||
Packages | ||
.build/ | ||
xcuserdata | ||
DerivedData/ | ||
# *.xcodeproj | ||
|
||
# fastlane | ||
# It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the | ||
# screenshots whenever they are needed. | ||
# For more information about the recommended setup visit: | ||
# https://docs.fastlane.tools/best-practices/source-control/#source-control | ||
|
||
fastlane/report.xml | ||
fastlane/Preview.html | ||
fastlane/screenshots/**/*.png | ||
fastlane/test_output | ||
|
||
# Code Injection | ||
# After new code Injection tools there's a generated folder /iOSInjectionProject | ||
# https://github.com/johnno1962/injectionforxcode | ||
|
||
iOSInjectionProject/ | ||
|
||
### Xcode ### | ||
# Xcode | ||
# gitignore contributors: remember to update Global/Xcode.gitignore, Objective-C.gitignore & Swift.gitignore | ||
|
||
## User settings | ||
|
||
## compatibility with Xcode 8 and earlier (ignoring not required starting Xcode 9) | ||
|
||
## compatibility with Xcode 3 and earlier (ignoring not required starting Xcode 4) | ||
|
||
## Xcode Patch | ||
*.xcodeproj/* | ||
!*.xcodeproj/project.pbxproj | ||
!*.xcodeproj/xcshareddata/ | ||
!*.xcworkspace/contents.xcworkspacedata | ||
/*.gcno | ||
|
||
### Xcode Patch ### | ||
**/xcshareddata/WorkspaceSettings.xcsettings | ||
|
||
# End of https://www.gitignore.io/api/xcode,swift,cocoapods | ||
*.DS_Store | ||
|
||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
// | ||
// LabelsCollectionViewCell.swift | ||
// issue-tracker | ||
// | ||
// Created by 양준혁 on 2021/06/13. | ||
// | ||
|
||
import UIKit | ||
import SnapKit | ||
|
||
class LabelsCollectionViewCell: UICollectionViewCell { | ||
static var identifiers = "LabelsCollectionViewCell" | ||
|
||
let label: PaddingLabel = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. private 으로 둘 수 있지 않을까요? 빠르게 개발하시더라도 private 을 둬야하는지 고민하는 것은 습관을 들이셔야 합니다 ㅎㅎ 이 부분 말고도 외부에서 접근안하는 변수나 메소드는 private 처리 부탁드립니다. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 다음 PR에 적용시키도록 하겠습니다!👍 |
||
var label = PaddingLabel(withInsets: 0, 0, 10, 10) | ||
label.textAlignment = .center | ||
label.textColor = .white | ||
label.layer.masksToBounds = true | ||
label.layer.cornerRadius = 15 | ||
return label | ||
}() | ||
|
||
override init(frame: CGRect) { | ||
super.init(frame: frame) | ||
addSubview(label) | ||
setupAutolayout() | ||
} | ||
|
||
required init?(coder: NSCoder) { | ||
super.init(coder: coder) | ||
addSubview(label) | ||
setupAutolayout() | ||
} | ||
|
||
func setupAutolayout() { | ||
label.snp.makeConstraints { label in | ||
label.edges.equalToSuperview() | ||
} | ||
} | ||
|
||
func configure(title: String, color: String) { | ||
label.text = title | ||
label.backgroundColor = UIColor.hexStringToUIColor(hex: color) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# Uncomment the next line to define a global platform for your project | ||
# platform :ios, '9.0' | ||
|
||
target 'issue-tracker' do | ||
# Comment the next line if you don't want to use dynamic frameworks | ||
use_frameworks! | ||
pod 'SwiftLint' | ||
|
||
# Pods for issue-tracker | ||
|
||
target 'issue-trackerTests' do | ||
inherit! :search_paths | ||
# Pods for testing | ||
end | ||
|
||
target 'issue-trackerUITests' do | ||
# Pods for testing | ||
end | ||
|
||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
PODS: | ||
- SwiftLint (0.43.1) | ||
|
||
DEPENDENCIES: | ||
- SwiftLint | ||
|
||
SPEC REPOS: | ||
trunk: | ||
- SwiftLint | ||
|
||
SPEC CHECKSUMS: | ||
SwiftLint: 99f82d07b837b942dd563c668de129a03fc3fb52 | ||
|
||
PODFILE CHECKSUM: d93da15071a83784721d7d111568e7103ab0017e | ||
|
||
COCOAPODS: 1.10.1 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분 protocol를 만들어서 적용하는 방법도 있습니다.
찾아보시고 괜찮으면 protocol 만들어서 사용하시는 것도 좋을 것 같아요 👍