Skip to content

Commit

Permalink
[BE/#28] Fix : 이슈 상세 정보 JSON의 일부 필드의 키 이름 변경
Browse files Browse the repository at this point in the history
- issueDetails -> issue
- createdDateTime -> createdAt
- assigneesInfo -> assigneeInfo
  • Loading branch information
MuseopKim committed Jun 15, 2020
1 parent c7fcdd1 commit 605ae4d
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 24 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,14 @@
import com.codesquad.issuetracker.ragdoll.vo.commentVO.CommentDetails;
import com.codesquad.issuetracker.ragdoll.vo.issueVO.IssueDetails;
import com.codesquad.issuetracker.ragdoll.vo.labelVO.LabelInformation;
import com.codesquad.issuetracker.ragdoll.vo.labelVO.LabelSummary;
import com.codesquad.issuetracker.ragdoll.vo.milestoneVO.MilestoneInformation;
import com.codesquad.issuetracker.ragdoll.vo.userVO.UserSummary;

import java.util.List;

public class DetailedInformationOfIssueDto {

private IssueDetails issueDetails;
private IssueDetails issue;

private List<CommentDetails> comments;

Expand All @@ -23,20 +22,20 @@ public class DetailedInformationOfIssueDto {

public DetailedInformationOfIssueDto() {}

public DetailedInformationOfIssueDto(IssueDetails issueDetails, List<CommentDetails> comments, LabelInformation labelInfo, MilestoneInformation milestoneInfo, List<UserSummary> assigneeInfo) {
this.issueDetails = issueDetails;
public DetailedInformationOfIssueDto(IssueDetails issue, List<CommentDetails> comments, LabelInformation labelInfo, MilestoneInformation milestoneInfo, List<UserSummary> assigneeInfo) {
this.issue = issue;
this.comments = comments;
this.labelInfo = labelInfo;
this.milestoneInfo = milestoneInfo;
this.assigneeInfo = assigneeInfo;
}

public IssueDetails getIssueDetails() {
return issueDetails;
public IssueDetails getIssue() {
return issue;
}

public void setIssueDetails(IssueDetails issueDetails) {
this.issueDetails = issueDetails;
public void setIssue(IssueDetails issue) {
this.issue = issue;
}

public List<CommentDetails> getComments() {
Expand Down Expand Up @@ -72,14 +71,14 @@ public void setAssigneeInfo(List<UserSummary> assigneeInfo) {
}

public static class Builder {
private IssueDetails issueDetails;
private IssueDetails issue;
private List<CommentDetails> comments;
private LabelInformation labelInfo;
private MilestoneInformation milestoneInfo;
private List<UserSummary> assigneeInfo;

public Builder issueDeatils(IssueDetails issueDetails) {
this.issueDetails = issueDetails;
public Builder issue(IssueDetails issue) {
this.issue = issue;
return this;
}

Expand All @@ -98,13 +97,13 @@ public Builder milestoneInfo(MilestoneInformation milestoneInfo) {
return this;
}

public Builder assigneesInfo(List<UserSummary> assigneesInfo) {
this.assigneeInfo = assigneesInfo;
public Builder assigneeInfo(List<UserSummary> assigneeInfo) {
this.assigneeInfo = assigneeInfo;
return this;
}

public DetailedInformationOfIssueDto build() {
return new DetailedInformationOfIssueDto(issueDetails, comments, labelInfo, milestoneInfo, assigneeInfo);
return new DetailedInformationOfIssueDto(issue, comments, labelInfo, milestoneInfo, assigneeInfo);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public DetailedInformationOfIssueDto showIssueDetails(Long issueId) {
return CommentDetails.create(commenter, comment.getDescription(), comment.getCreatedDateTime());
}).collect(Collectors.toList());
return new DetailedInformationOfIssueDto.Builder()
.issueDeatils(mapToIssueDetails(issue))
.issue(mapToIssueDetails(issue))
.comments(comments)
.labelInfo(labelService.findAllLabels())
.milestoneInfo(milestoneService.findAllMilestones())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@ public class CommentDetails {

private String description;

private LocalDateTime createdDateTime;
private LocalDateTime createdAt;

public CommentDetails() {}

private CommentDetails(UserSummary commenter, String description, LocalDateTime createdDateTime) {
private CommentDetails(UserSummary commenter, String description, LocalDateTime createdAt) {
this.commenter = commenter;
this.description = description;
this.createdDateTime = createdDateTime;
this.createdAt = createdAt;
}

public static CommentDetails create(UserSummary commenter, String description, LocalDateTime createdDateTime) {
return new CommentDetails(commenter, description, createdDateTime);
public static CommentDetails create(UserSummary commenter, String description, LocalDateTime createdAt) {
return new CommentDetails(commenter, description, createdAt);
}

public UserSummary getCommenter() {
Expand All @@ -41,11 +41,11 @@ public void setDescription(String description) {
this.description = description;
}

public LocalDateTime getCreatedDateTime() {
return createdDateTime;
public LocalDateTime getCreatedAt() {
return createdAt;
}

public void setCreatedDateTime(LocalDateTime createdDateTime) {
this.createdDateTime = createdDateTime;
public void setCreatedAt(LocalDateTime createdAt) {
this.createdAt = createdAt;
}
}

0 comments on commit 605ae4d

Please sign in to comment.