Skip to content

Commit

Permalink
test(pkg/pgsql): unit testing for deallocate stmt
Browse files Browse the repository at this point in the history
Signed-off-by: Jeronimo Irazabal <jeronimo.irazabal@gmail.com>
jeroiraz committed Nov 7, 2023
1 parent 02d6190 commit 86d273c
Showing 4 changed files with 3 additions and 15 deletions.
7 changes: 0 additions & 7 deletions pkg/pgsql/errors/errors.go
Original file line number Diff line number Diff line change
@@ -34,7 +34,6 @@ var ErrExpectedQueryMessage = errors.New("expected query message")
var ErrUseDBStatementNotSupported = errors.New("SQL statement not supported")
var ErrSSLNotSupported = errors.New("SSL not supported")
var ErrMaxStmtNumberExceeded = errors.New("maximum number of statements in a single query exceeded")
var ErrNoStatementFound = errors.New("no statement found")
var ErrMessageCannotBeHandledInternally = errors.New("message cannot be handled internally")
var ErrMaxParamsNumberExceeded = errors.New("number of parameters exceeded the maximum limit")
var ErrParametersValueSizeTooLarge = errors.New("provided parameters exceeded the maximum allowed size limit")
@@ -79,12 +78,6 @@ func MapPgError(err error) (er bm.ErrorResp) {
bm.Message(err.Error()),
bm.Hint("at the moment is possible to receive only 1 statement. Please split query or use a single statement"),
)
case errors.Is(err, ErrNoStatementFound):
er = bm.ErrorResponse(bm.Severity(pgmeta.PgSeverityError),
bm.Code(pgmeta.ProgramLimitExceeded),
bm.Message(err.Error()),
bm.Hint("provide at least one statement"),
)
case errors.Is(err, ErrParametersValueSizeTooLarge):
er = bm.ErrorResponse(bm.Severity(pgmeta.PgSeverityError),
bm.Code(pgmeta.DataException),
2 changes: 0 additions & 2 deletions pkg/pgsql/errors/errors_test.go
Original file line number Diff line number Diff line change
@@ -29,8 +29,6 @@ func TestMapPgError(t *testing.T) {
err = ErrMaxStmtNumberExceeded
be = MapPgError(err)
require.NotNil(t, be)
err = ErrNoStatementFound
be = MapPgError(err)
require.NotNil(t, be)
err = ErrParametersValueSizeTooLarge
be = MapPgError(err)
3 changes: 3 additions & 0 deletions pkg/pgsql/server/pgsql_integration_test.go
Original file line number Diff line number Diff line change
@@ -728,6 +728,9 @@ func TestPgsqlServer_VersionStatement(t *testing.T) {
err = db.QueryRow("SELECT version()").Scan(&version)
require.NoError(t, err)
require.Equal(t, pgmeta.PgsqlProtocolVersionMessage, version)

_, err = db.Exec("DEALLOCATE \"_PLAN0x7fb2c0822800\"")
require.NoError(t, err)
}

func TestPgsqlServerSetStatement(t *testing.T) {
6 changes: 0 additions & 6 deletions pkg/pgsql/server/query_machine.go
Original file line number Diff line number Diff line change
@@ -103,12 +103,6 @@ func (s *session) QueryMachine() error {
s.HandleError(pserr.ErrMaxStmtNumberExceeded)
continue
}
if len(stmts) == 0 {
waitForSync = extQueryMode
s.HandleError(pserr.ErrNoStatementFound)
continue
}

if paramCols, resCols, err = s.inferParamAndResultCols(stmts[0]); err != nil {
waitForSync = extQueryMode
s.HandleError(err)

0 comments on commit 86d273c

Please sign in to comment.