refactor: Add phpDoc for Filters
#9446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
approved these changes
Feb 10, 2025
samsonasik
approved these changes
Feb 10, 2025
datamweb
reviewed
Feb 10, 2025
| @@ -113,6 +113,8 @@ class Filters extends BaseConfig | |||
| * | |||
| * Example: | |||
| * 'isLoggedIn' => ['before' => ['account/*', 'profiles/*']] | |||
| * | |||
| * @var array<string, array<string, list<string>>> | |||
There was a problem hiding this comment.
What do you think about this more precise PHPDoc structure? Does it meet your expectations for clarity and accuracy, or would you prefer a simpler approach?
Suggested change
| * @var array<string, array<string, list<string>>> | |
| * @var array<string, array{before?: string[], after?: string[]}> |
michalsn
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missed PHPDoc in system/Config/Filters.php.
Checklist: