Add search endpoint logic. #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osoken
reviewed
Jan 31, 2025
api/pyproject.toml
Outdated
| @@ -61,7 +61,7 @@ dev=[ | |||
| "httpx", | |||
| ] | |||
| prod=[ | |||
| "birdxplorer_common @ git+https://github.com/codeforjapan/BirdXplorer.git@main#subdirectory=common", | |||
| "birdxplorer_common @ git+https://github.com/codeforjapan/BirdXplorer.git@feature/138#subdirectory=common", | |||
osoken
reviewed
Jan 31, 2025
osoken
reviewed
Feb 3, 2025
common/birdxplorer_common/storage.py
Outdated
There was a problem hiding this comment.
search_notes_with_posts と count_search_results のフィルタを適用する部分は private 関数に切り出してまとめてもいいかもしれません。（他のところにもありますので、一気にまとめたくなるかもしれませんが、一旦これだけやる想定です）
sushichan044
requested changes
Feb 5, 2025
api/birdxplorer_api/routers/data.py
Outdated
Comment on lines
513
to
522
| # Generate pagination URLs | ||
| base_url = str(request.url).split("?")[0] | ||
| next_offset = offset + limit | ||
| prev_offset = max(offset - limit, 0) | ||
| next_url = None | ||
| if next_offset < total_count: | ||
| next_url = f"{base_url}?offset={next_offset}&limit={limit}" | ||
| prev_url = None | ||
| if offset > 0: | ||
| prev_url = f"{base_url}?offset={prev_offset}&limit={limit}" |
There was a problem hiding this comment.
[MUST] (Viewer ユーザー影響あり)
?post_includes_text=地震&offset=0&limit=4 のように limit / offset 以外が指定されたクエリの場合、
next が ?offset=4&limit=4 となってしまうので urllib.parse を使うなどして現在のクエリをマージする実装にしないと予想外の挙動になりそうです！
api/birdxplorer_api/routers/data.py
Outdated
Comment on lines
453
to
456
| if note_created_at_from is not None and isinstance(note_created_at_from, str): | ||
| note_created_at_from = ensure_twitter_timestamp(note_created_at_from) | ||
| if note_created_at_to is not None and isinstance(note_created_at_to, str): | ||
| note_created_at_to = ensure_twitter_timestamp(note_created_at_to) |
There was a problem hiding this comment.
[MUST]
ensure_twitter_timestamp に現在時刻より未来の値を渡すと
OverflowError: signed integer is greater than maximum が出ていそうです。
これは入力されうる異常値なので、ハンドリングして DB クエリに 異常値を渡さないように変更したほうが良さそうです。
[imo]
ensure_twitter_timestamp からは一般的な Error を投げて API Handler 側で HTTPException を投げ直すのが見通しが良さそうに思いました！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoteとPostを統合的に検索する
/api/v1/data/searchを実装。変更点
BirdXplorer/api/birdxplorer_api/routers/data.py
Line 418 in e4fce05
BirdXplorer/common/birdxplorer_common/storage.py
Line 510 in e4fce05
BirdXplorer/common/birdxplorer_common/storage.py
Line 604 in e4fce05
テストコードは
./tests/test_search.pyに記述メモ