-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagger UI 上のドキュメントを整備する #126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0191a3a
to
3fc71c3
Compare
3fc71c3
to
c793b24
Compare
41d8d13
to
34e53b2
Compare
34e53b2
to
20f0874
Compare
20f0874
to
25a9a0b
Compare
Note PR description へ転記済 note: レスポンスへの documentation は二箇所に分ける
|
d0f9f95
to
df69636
Compare
Add docs to properties of Topic, Note, Post, PaginationMeta Post.link のcomputed_field と property の順序が逆だった これを正しくしたところ Post.link の doctest が壊れた 純粋な文字列合成なのでテストを消しても問題ないと判断して削除
df69636
to
259e19a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outline
#122
Swagger UI /
openapi.json
で確認できる API 仕様をより分かりやすいものにする。クエリパラメータ
Path()
やQuery()
に対して引数でドキュメントを渡すことで自動的に整備できる。レスポンス
Annotated
とField(description="", examples=[])
を使って Type Hint でドキュメントを付与詳細
Docs
/posts
/notes
/topics
/user-enrollments
ある程度 Docs 書けたら