Fixed the "shen" test example which I had previously disabled in PR #213 upon auto-generating input files from the corresponding excel sheet #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upon auto-generating input files from the corresponding excel sheet Fixes #214
eriksynn
requested review from
alanisaac,
debajyotid2,
dwindleduck,
jkwan2011 and
stevebreit
debajyotid2
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214
I met with Steve Breit yesterday to debug the Shen example test case. We determined that I had committed the wrong version of the heat load excel sheet for that example. We also determined that the estimated balance point had been set incorrectly in the spreadsheet. Once appropriate corrections were made in the excel sheet and new json and csv files were generated from it, the test passed. We also decided to update the readme file in the cases/examples directory to more explicitely describe how these examples are generated now from the source excel sheets.