177 upgrade the python version of rules engine to 3.11.3 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Go for it! |
eriksynn
approved these changes
May 17, 2024
debajyotid2
deleted the
177-upgrade-the-python-version-of-rules-engine-to-3113
branch
Sounds good. |
eriksynn
added a commit
that referenced
this pull request
May 21, 2024
eriksynn
added a commit
that referenced
this pull request
May 21, 2024
eriksynn
added a commit
that referenced
this pull request
May 21, 2024
* added whole home heat loss rate to billing period outputs Co-authored-by: Debajyoti Debnath <[email protected]> Co-authored-by: eriksynn <[email protected]> Co-authored-by: AdamFinkle <[email protected]> * lint * First attempt to add whole_home_heat_loss_rate test from example data * Another approach to dynamically decorating a class * Switched to using __dict__ to decorate the NGBillingRecordClass * Final solution to adding billing period heat loss to example data * Revert to subclass approach leveraging Sequence type to appease mypy * Generate new example data from HLA spreadsheet examples and ensure tests pass. * Check for more specific ua column heading and add more descriptive comment. * Switch to built-in list to align with Deb's PR #179 changes. * Align changes with Deb's PR #179 * Attempt to fix lint error in import statement formatting --------- Co-authored-by: Alan Pinkert <[email protected]> Co-authored-by: Debajyoti Debnath <[email protected]> Co-authored-by: eriksynn <[email protected]> Co-authored-by: AdamFinkle <[email protected]>
AdamFinkle
pushed a commit
to AdamFinkle/home-energy-analysis-tool
that referenced
this pull request
May 22, 2024
…on#179) * Modify python version to 3.11.3 in pyproject.toml. * Replace List with list in type annotations. * Change mixin of str and Enum to StrEnum in NaturalGasCompany.
AdamFinkle
added a commit
to AdamFinkle/home-energy-analysis-tool
that referenced
this pull request
May 22, 2024
* added whole home heat loss rate to billing period outputs Co-authored-by: Debajyoti Debnath <[email protected]> Co-authored-by: eriksynn <[email protected]> Co-authored-by: AdamFinkle <[email protected]> * lint * First attempt to add whole_home_heat_loss_rate test from example data * Another approach to dynamically decorating a class * Switched to using __dict__ to decorate the NGBillingRecordClass * Final solution to adding billing period heat loss to example data * Revert to subclass approach leveraging Sequence type to appease mypy * Generate new example data from HLA spreadsheet examples and ensure tests pass. * Check for more specific ua column heading and add more descriptive comment. * Switch to built-in list to align with Deb's PR codeforboston#179 changes. * Align changes with Deb's PR codeforboston#179 * Attempt to fix lint error in import statement formatting --------- Co-authored-by: Alan Pinkert <[email protected]> Co-authored-by: Debajyoti Debnath <[email protected]> Co-authored-by: eriksynn <[email protected]> Co-authored-by: AdamFinkle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
pyproject.toml,requirements-dev.txtandrequirements.txtfiles.List(replaced withlist).strandEnumreplaced withStrEnum.