Use string enums for natural gas company #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plocket
reviewed
Apr 30, 2024
I assume in reference to this: class NaturalGasCompany(str, Enum):This is a class definition, and in this case, this is a class implementing multiple inheritance. As to why we use it here, that's the recommended solution for making string-backed enums. |
|
@alanisaac We could probably use |
Oh neat, that's new(er). I'm still used to writing in older versions. Will update |
|
LGTM |
AdamFinkle
pushed a commit
to AdamFinkle/home-energy-analysis-tool
that referenced
this pull request
May 22, 2024
* use string enums for natural gas company * use StrEnum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167