Updated code to fix rules_engine tests such that they all pass #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated RulesEngineResult to derive from BaseModel Updated various places where we had neglected to change inclusion_override to analysis_type_override Added indirection from RulesEngineResult to SummaryOutput in test_engine.py Fixed positional argument errors BillingPeriod test env setup
eriksynn
requested review from
alanisaac,
debajyotid2,
dwindleduck,
jkwan2011 and
thatoldplatitude
jkwan2011
approved these changes
Apr 23, 2024
jkwan2011
deleted the
fix-normalizedbillrecord-and-analysistypeoverride-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated NormalizedBillingPeriodRecord to derive from BaseModel
Updated RulesEngineResult to derive from BaseModel
Updated various places where we had neglected to change inclusion_override to analysis_type_override
Added indirection from RulesEngineResult to SummaryOutput in test_engine.py
Fixed positional argument errors BillingPeriod test env setup