Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate energy use fields #160

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Validate energy use fields #160

merged 6 commits into from
Apr 9, 2024

Conversation

thadk
Copy link
Member

@thadk thadk commented Apr 4, 2024

image

thadk and others added 6 commits March 20, 2024 01:01
Co-authored-by: plocket <[email protected]>
Co-authored-by: Clayton Schneider <[email protected]>
Co-authored-by: Leopardfoot <[email protected]>
Co-authored-by: Camden Blatchly <[email protected]>
Co-authored-by: plocket <[email protected]>
Co-authored-by: Clayton Schneider <[email protected]>
Co-authored-by: plocket <[email protected]>
Co-authored-by: Clayton Schneider <[email protected]>
Co-authored-by: AISHWARYA RAJA <[email protected]>
@thadk
Copy link
Member Author

thadk commented Apr 5, 2024

nota bene: when squashing and merging is on it is important to start a fresh branch because then you're not double squashing commits. I think I handled this though.

Copy link
Collaborator

@plocket plocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fine toothed comb isn't fast enough to absorb it all this way, but last week it looked pretty good and it looks the same as last week 👍

@plocket plocket merged commit bb8fc68 into main Apr 9, 2024
12 checks passed
AdamFinkle pushed a commit to AdamFinkle/home-energy-analysis-tool that referenced this pull request May 22, 2024
* WIP: explore abstract in zod types

Co-authored-by: plocket <[email protected]>
Co-authored-by: Clayton Schneider <[email protected]>
Co-authored-by: Leopardfoot <[email protected]>
Co-authored-by: Camden Blatchly <[email protected]>

* Added zod types for CurrentHeatingSystem and change types/index.ts to zod.

Co-authored-by: Camden Blatchly <[email protected]>
Co-authored-by: plocket <[email protected]>

* fix display analysis+charts to use zod

* implement CurrentHeatingSystem form in zod/conform

Co-authored-by: plocket <[email protected]>
Co-authored-by: Clayton Schneider <[email protected]>

* update TODOs with upload

Co-authored-by: plocket <[email protected]>
Co-authored-by: Clayton Schneider <[email protected]>
Co-authored-by: AISHWARYA RAJA <[email protected]>

---------

Co-authored-by: plocket <[email protected]>
Co-authored-by: Clayton Schneider <[email protected]>
Co-authored-by: Leopardfoot <[email protected]>
Co-authored-by: Camden Blatchly <[email protected]>
Co-authored-by: AISHWARYA RAJA <[email protected]>
@thadk thadk deleted the energy_use branch August 21, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants