refactor analysis type name #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Debajyoti Debnath <[email protected]> Co-authored-by: eriksynn <[email protected]> Co-authored-by: dwindleduck <[email protected]>
Co-authored-by: eriksynn <[email protected]> Co-authored-by: thatoldplatitude <[email protected]> Co-authored-by: Jonathan Kwan <[email protected]> Co-authored-by: dwindleduck <[email protected]> Co-authored-by: Debajyoti Debnath <[email protected]>
…n entry point Co-authored-by: Debajyoti Debnath <[email protected]> Co-authored-by: thatoldplatitude <[email protected]> Co-authored-by: eriksynn <[email protected]> Co-authored-by: AdamFinkle <[email protected]>
Updated RulesEngineResult to derive from BaseModel Updated various places where we had neglected to change inclusion_override to analysis_type_override Added indirection from RulesEngineResult to SummaryOutput in test_engine.py Fixed positional argument errors BillingPeriod test env setup
Co-authored-by: Debajyoti Debnath <[email protected]> Co-authored-by: dwindleduck <[email protected]> Co-authored-by: eriksynn <[email protected]> Co-authored-by: Alan Pinkert <[email protected]>
Co-authored-by: Debajyoti Debnath <[email protected]> Co-authored-by: dwindleduck <[email protected]> Co-authored-by: eriksynn <[email protected]> Co-authored-by: Alan Pinkert <[email protected]> Co-authored-by: AdamFinkle <[email protected]>
jkwan2011
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start for making the rules engine output data that the frontend can consume for the billing periods table. Will eventually address #137