Skip to content

Commit

Permalink
Refactor: Rename "sample_summary_inputs" to "sample_heat_load_inputs"
Browse files Browse the repository at this point in the history
Co-authored-by: AdamFinkle <[email protected]>
Co-authored-by: Ethan-Strominger <[email protected]>
  • Loading branch information
3 people committed Dec 10, 2024
1 parent be7ab41 commit ec82535
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion python/src/rules_engine/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ def _calculate_balance_point_and_ua(
stdev_pct_max: float = 0.10,
max_stdev_pct_diff: float = 0.01,
next_balance_point_sensitivity: float = 0.5,
) -> None:
) -> any:
"""
Calculates the estimated balance point and UA coefficient for
the home, removing UA outliers based on a normalized standard
Expand Down
14 changes: 7 additions & 7 deletions python/tests/test_rules_engine/test_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def sample_processed_energy_bill_inputs_with_outlier() -> (


@pytest.fixture()
def sample_summary_inputs() -> HeatLoadInput:
def sample_heat_load_inputs() -> HeatLoadInput:
heat_sys_efficiency = 0.88

living_area = 1000
Expand Down Expand Up @@ -316,9 +316,9 @@ def test_get_average_indoor_temperature():
assert engine.get_average_indoor_temperature(set_temp, setback, setback_hrs) == 66


def test_bp_ua_estimates(sample_summary_inputs, sample_processed_energy_bill_inputs):
def test_bp_ua_estimates(sample_heat_load_inputs, sample_processed_energy_bill_inputs):
home = engine.Home.calculate(
sample_summary_inputs,
sample_heat_load_inputs,
sample_processed_energy_bill_inputs,
dhw_input=None,
initial_balance_point=58,
Expand All @@ -335,10 +335,10 @@ def test_bp_ua_estimates(sample_summary_inputs, sample_processed_energy_bill_inp


def test_bp_ua_with_outlier(
sample_summary_inputs, sample_processed_energy_bill_inputs_with_outlier
sample_heat_load_inputs, sample_processed_energy_bill_inputs_with_outlier
):
home = engine.Home.calculate(
sample_summary_inputs,
sample_heat_load_inputs,
sample_processed_energy_bill_inputs_with_outlier,
dhw_input=None,
initial_balance_point=58,
Expand Down Expand Up @@ -417,12 +417,12 @@ def test_convert_to_intermediate_processed_energy_bills(


def test_get_outputs_normalized(
sample_summary_inputs,
sample_heat_load_inputs,
sample_temp_inputs,
sample_normalized_processed_energy_bill_inputs,
):
rules_engine_result = engine.get_outputs_normalized(
sample_summary_inputs,
sample_heat_load_inputs,
None,
sample_temp_inputs,
sample_normalized_processed_energy_bill_inputs,
Expand Down

0 comments on commit ec82535

Please sign in to comment.