Cleanup

codeforboston · Apr 24, 2024 · d4a4068 · d4a4068
1 parent e4fadbc
commit d4a4068
Showing 1 changed file with 0 additions and 39 deletions.
diff --git a/rules-engine/src/rules_engine/engine.py b/rules-engine/src/rules_engine/engine.py
@@ -358,45 +358,6 @@ def _initialize_billing_periods(self, billing_periods: List[BillingPeriod]) -> N
         self.bills_summer = []
         self.bills_shoulder = []
 
-        # 'Inclusion' in calculations is now determined by two variables:
-        # billing_period.default_inclusion_by_calculation: bool
-        # billing_period.inclusion_override: bool (False by default)
-        #
-        # Our logic around the AnalysisType can now disallow
-        # a billing_period from being included or overridden
-        # by marking it as NOT_ALLOWED_IN_CALCULATIONS
-        #
-        # Options for billing_period.analysis_type:
-        # ALLOWED_HEATING_USAGE = 1 # winter months - allowed in heating usage calculations
-        # ALLOWED_NON_HEATING_USAGE = -1 # summer months - allowed in non-heating usage calculations
-        # NOT_ALLOWED_IN_CALCULATIONS = 0 # shoulder months that fall outside reasonable bounds
-        #
-        # Use HDDs to determine if shoulder months
-        # are heating or non-heating or not allowed,
-        # or included or excluded
-        #
-        # Rough calculations from Steve, this will be ammended:
-        # IF hdds is within 70% or higher of max, allowed
-        # less than 25% of max, not allowed
-        #
-
-        # IF winter months
-        #       analysis_type = ALLOWED_HEATING_USAGE
-        #       default_inclusion_by_calculation = True
-        # ELSE IF summer months
-        #       analysis_type = ALLOWED_NON_HEATING_USAGE
-        #       default_inclusion_by_calculation = True
-        # ELSE IF shoulder months
-        #       IF hdds < 25% || hdds > 70%
-        #           analysis_type = NOT_ALLOWED_IN_CALCULATIONS
-        #           default_inclusion_by_calculation = False
-        #       IF 25% < hdds < 50%
-        #           analysis_type = ALLOWED_NON_HEATING_USAGE
-        #           default_inclusion_by_calculation = False
-        #       IF 50% < hdds < 70%
-        #           analysis_type = ALLOWED_HEATING_USAGE
-        #           default_inclusion_by_calculation = False
-
         # winter months 1; summer months -1; shoulder months 0
         for billing_period in billing_periods:
             billing_period.set_initial_balance_point(self.balance_point)