Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCAP-506] - Implement making ccrr name dynamic #1075

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[CCAP-506] - Implement making ccrr name dynamic #1075

wants to merge 5 commits into from

Conversation

analoo
Copy link
Contributor

@analoo analoo commented Jan 23, 2025 •
edited by jira bot
Loading

🔗 Jira ticket

CCAP-506

✍️ Description

  • Sets CCRR Name based at the same time as org name
  • Logic:
    • Check home zip code to set CCRR
    • Check county or zip code provided.

📷 Design reference

✅ Completion tasks

  • Added relevant tests
  • Meets acceptance criteria

@enyia21 enyia21 temporarily deployed to il-gcc-ccap-506-set-ccr-ezloz7 January 23, 2025 22:09 Inactive
@analoo analoo marked this pull request as ready for review January 23, 2025 22:42
@github-actions github-actions bot requested a review from cram-cfa January 23, 2025 22:42
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-506-set-ccr-ezloz7 January 23, 2025 22:42 Inactive
@analoo analoo changed the title Implement making ccrr name dynamic [CCAP-506] - Implement making ccrr name dynamic Jan 23, 2025
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-506-set-ccr-ezloz7 January 23, 2025 22:58 Inactive
@analoo analoo force-pushed the CCAP-506-set-ccrrName-from-organizationId branch from b578846 to 5e26032 Compare January 24, 2025 22:11
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-506-set-ccr-ezloz7 January 24, 2025 22:11 Inactive
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-506-set-ccr-ezloz7 January 24, 2025 22:12 Inactive
analoo
analoo commented Jan 24, 2025
View reviewed changes
src/main/java/org/ilgcc/app/submission/actions/SetOrganizationIdAndCCRRName.java Outdated

Map<String, Object> inputData = submission.getInputData();

if (hasValidValue(inputData, UNVALIDATED_ZIPCODE_INPUT_NAME)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the sentry issue because it checks that the zip code data is not an empty string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cram-cfa cram-cfa cram-cfa approved these changes

Assignees

@analoo analoo

Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@analoo @cram-cfa @enyia21