Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert unsupported characters #455

Closed
wants to merge 6 commits into from
Closed

Conversation

enyia21
Copy link
Contributor

@enyia21 enyia21 commented Nov 27, 2023

No description provided.

@enyia21 enyia21 requested a review from cy-by November 27, 2023 18:56
@cy-by cy-by force-pushed the convert-unsupported-characters branch from 173a626 to d0c8aca Compare November 27, 2023 22:30
builder.append('?');
}

System.out.println("test");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need to print out test?

Suggested change
System.out.println("test");

Copy link
Contributor

@cy-by cy-by left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and thing work as I expected. Left a comment to remove a println.

2023-11-27 at 16 40 13@2x

@enyia21 enyia21 requested a review from cy-by November 28, 2023 16:06
@bseeger
Copy link
Contributor

bseeger commented Nov 28, 2023

Is this one superseded by the one about OpenPDF?

@cy-by
Copy link
Contributor

cy-by commented Dec 5, 2023

@enyia21 I think we can close this PR now?

@spokenbird
Copy link
Contributor

Closing as we won't be usign this approach.

@spokenbird spokenbird closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants