Issues - RequesetToken 리턴 타입 수정 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc7303
suggested changes
Jul 30, 2021
There was a problem hiding this comment.
@limsg1234 작업해주셔서 너무 감사합니다! 👍
몇가지 의견을 남겨드렸습니다. 확인 후 편하게 의견 부탁드리겠습니다 :)
easycodefgo.go
Outdated
| @@ -267,3 +271,7 @@ func checkNeedValueInTwoWayInfo(twoWayInfo map[string]interface{}) bool { | |||
| } | |||
| return true | |||
| } | |||
|
|
|||
| func convertToString(tokenMap map[string]interface{}) (string){ | |||
There was a problem hiding this comment.
단지 캐스팅하는 로직이기 때문에 함수로 따로 빼지 않아도 될 것 같은데 어떻게 생각하시나요~?
easycodefgo.go
Outdated
Comment on lines
159
to
160
| token, err := requestToken(self.clientID, self.clientSecret) | ||
| return convertToString(token), err |
There was a problem hiding this comment.
requestToken()에서 토큰을 확인해서 반환하는 것은 어떨까요?
확인하는 과정에서 토큰이 존재하지 않거나, 예상하지 못한 응답일경우 관련 에러를 반환해주는게 좋을 것 같다고 생각합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues 의 RequestToken 수정에 대한 수정입니다.
리턴타입을 map 에서 string 으로 교체했습니다.