Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: React migration - Issue list CY-6604 #1836

Merged
merged 15 commits into from
Oct 18, 2023
Merged

feat: React migration - Issue list CY-6604 #1836

merged 15 commits into from
Oct 18, 2023

Conversation

nicklem
Copy link
Contributor

@nicklem nicklem commented Aug 16, 2023 •
edited
Loading

@github-actions github-actions bot temporarily deployed to Netlify August 16, 2023 12:59 Inactive
@nicklem nicklem changed the title wip: Temporary screenshots feat: Issues page migration CY-6604 Aug 16, 2023
@nicklem nicklem self-assigned this Aug 17, 2023
@nicklem nicklem added the don't merge Don't merge this pull request yet label Aug 17, 2023
@github-actions github-actions bot temporarily deployed to Netlify August 21, 2023 10:34 Inactive
@nicklem
Copy link
Contributor Author

nicklem commented Aug 28, 2023

@dependabot rebase

@nicklem nicklem changed the title feat: Issues page migration CY-6604 feat: React migration - Issue list CY-6604 Sep 6, 2023
@github-actions github-actions bot temporarily deployed to Netlify September 6, 2023 10:02 Inactive
@github-actions github-actions bot temporarily deployed to Netlify September 11, 2023 13:45 Inactive
@nicklem
Copy link
Contributor Author

nicklem commented Sep 19, 2023

@dependabot rebase

@nicklem nicklem force-pushed the CY-6604-doc-update-documentation-for-issues-list-page branch from a754d14 to e65bc0e Compare September 19, 2023 14:22
@github-actions github-actions bot temporarily deployed to Netlify September 19, 2023 14:24 Inactive
@github-actions github-actions bot temporarily deployed to Netlify October 10, 2023 13:15 Inactive
@nicklem nicklem force-pushed the CY-6604-doc-update-documentation-for-issues-list-page branch from 7e672e9 to ae48357 Compare October 11, 2023 08:54
@github-actions github-actions bot temporarily deployed to Netlify October 11, 2023 08:56 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited
Loading

Overall readability score: 54.59 (🟢 +0.01)

File Readability
bitbucket-integration.md 47.62 (🔴 -1.72)
github-integration.md 52.64 (🔴 -0.73)
jira-integration.md 65.66 (🟢 +0.03)
commits.md 53.78 (🟢 +2.93)
issues.md 64 (🟢 +1.95)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
bitbucket-integration.md 47.62 35.78 11.86 13.7 13.81 7.86
  🔴 -1.72 🔴 -0.5 🔴 -0.35 🔴 -0.2 🔴 -0.3 🔴 -0.1
github-integration.md 52.64 35.57 11.02 13.4 13.29 7.1
  🔴 -0.73 🔴 -0.41 🔴 -0.23 🔴 -0.1 🟢 +0.05 🔴 -0.06
jira-integration.md 65.66 42.38 8.91 9 10.95 7.54
  🟢 +0.03 🟢 +0.31 🟢 +0.13 🟢 +0.2 🟢 +0.17 🔴 -0.24
commits.md 53.78 33.95 10.67 14.9 12.88 6.35
  🟢 +2.93 🟢 +1.22 🟢 +0.5 🟢 +0.9 🟢 +0.17 🟢 +0.1
issues.md 64 47.28 10 10.3 11.02 7.11
  🟢 +1.95 🟢 +0.5 🟢 +0.25 🟢 +0.5 🟢 +0.23 🟢 +0.12

Averages:

  Readability FRE GF ARI CLI DCRS
Average 54.59 43.29 10.86 12.28 12.48 7.84
  🟢 +0.01 🟢 +0.01 🟢 +0 🟢 +0.01 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@github-actions github-actions bot temporarily deployed to Netlify October 11, 2023 11:24 Inactive
nicklem
nicklem commented Oct 11, 2023
View reviewed changes
docs/repositories/issues.md Outdated Show resolved Hide resolved
nicklem
nicklem commented Oct 11, 2023
View reviewed changes
docs/repositories/issues.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to Netlify October 11, 2023 12:00 Inactive
nicklem
nicklem commented Oct 11, 2023
View reviewed changes
docs/repositories/issues.md Outdated Show resolved Hide resolved
@nicklem nicklem requested review from a team and claudiacarpinteiro October 11, 2023 12:03
@nicklem nicklem marked this pull request as ready for review October 11, 2023 12:05
@nicklem nicklem requested a review from a team as a code owner October 11, 2023 12:05
@github-actions github-actions bot temporarily deployed to Netlify October 12, 2023 12:08 Inactive
claudiacarpinteiro
claudiacarpinteiro reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@claudiacarpinteiro claudiacarpinteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @nicklem! 👍
I left some comments for your evaluation.

docs/repositories/issues.md Show resolved Hide resolved
docs/repositories/issues.md Outdated Show resolved Hide resolved
docs/repositories/issues.md Outdated Show resolved Hide resolved
docs/repositories/issues.md Outdated Show resolved Hide resolved
docs/repositories-configure/integrations/bitbucket-integration.md Outdated Show resolved Hide resolved
docs/repositories-configure/integrations/github-integration.md Outdated Show resolved Hide resolved
@nicklem @claudiacarpinteiro
feat: Apply suggestions from code review
d9b9e39 
Co-authored-by: Cláudia Carpinteiro <[email protected]>
@github-actions github-actions bot temporarily deployed to Netlify October 13, 2023 07:35 Inactive
@github-actions github-actions bot temporarily deployed to Netlify October 13, 2023 09:59 Inactive
@github-actions github-actions bot temporarily deployed to Netlify October 13, 2023 13:05 Inactive
@github-actions github-actions bot temporarily deployed to Netlify October 17, 2023 14:57 Inactive
@github-actions github-actions bot temporarily deployed to Netlify October 17, 2023 15:58 Inactive
@github-actions github-actions bot temporarily deployed to Netlify October 18, 2023 08:07 Inactive
joanasteodoro
joanasteodoro approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@joanasteodoro joanasteodoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

@nicklem nicklem enabled auto-merge (squash) October 18, 2023 10:23
@nicklem nicklem removed the don't merge Don't merge this pull request yet label Oct 18, 2023
@nicklem nicklem merged commit 673df81 into master Oct 18, 2023
@nicklem nicklem deleted the CY-6604-doc-update-documentation-for-issues-list-page branch October 18, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiacodacy claudiacodacy claudiacodacy left review comments

@joanasteodoro joanasteodoro joanasteodoro approved these changes

@claudiacarpinteiro claudiacarpinteiro Awaiting requested review from claudiacarpinteiro

@mrfyda mrfyda Awaiting requested review from mrfyda

Assignees

@nicklem nicklem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicklem @mrfyda @claudiacarpinteiro @joanasteodoro @claudiacodacy