Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance #16650

Merged
merged 2 commits into from
Jan 3, 2024
Merged

improve performance #16650

merged 2 commits into from
Jan 3, 2024

Conversation

star-e
Copy link
Contributor

@star-e star-e commented Jan 2, 2024

Fix performance problem of custom pipeline. Reducing calls of getXXXLights.
Improve performance of render graph construction. Empty unordered_map from msvc will allocate memory, which causes performance problem.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

github-actions bot commented Jan 2, 2024

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -65124,8 +65124,12 @@
             depthSlotName: string;
             shadowPass: any;
             forwardPass: any;
             postProcess: postProcess.PostProcess | undefined;
+            maxSpotLights: number;
+            maxSphereLights: number;
+            maxPointLights: number;
+            maxRangedDirLights: number;
             setClearFlag(clearFlag: gfx.ClearFlagBit): _cocos_rendering_post_process_utils_pass_context__PassContext;
             setClearColor(x: number, y: number, z: number, w: number): _cocos_rendering_post_process_utils_pass_context__PassContext;
             setClearDepthColor(x: number, y: number, z: number, w: number): _cocos_rendering_post_process_utils_pass_context__PassContext;
             version(): _cocos_rendering_post_process_utils_pass_context__PassContext;

@star-e star-e marked this pull request as ready for review January 3, 2024 02:06
@star-e star-e requested a review from minggo January 3, 2024 02:06
@star-e star-e merged commit 6dc6fed into cocos:v3.8.2 Jan 3, 2024
21 of 22 checks passed
cocos-robot pushed a commit to cocos-robot/engine that referenced this pull request Jan 3, 2024
minggo pushed a commit that referenced this pull request Jan 3, 2024
@star-e star-e deleted the v3.8.2-cyberpunk branch October 14, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants