libtcgtpm: use bindgen in build.rs instead of bindgen-cli in Makefile #606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had several issues in our CI because we forgot to install
bindgen-cli
used in the libtcgtpm/Makefile to generate the TPM bindings.Instead of using
bindgen-cli
(and then having as a requirement to have it installed), let's usebindgen
in build.rs, this way the dependency is handled directly by cargo.Let's also clean up the references to
libtcgtpm/src/bindings.rs
since bindings were already generated in the OUT_DIR.Remove the reference to install
bindgen-cli
in the CI workflows, Documentation, and container image.