Fix username caching #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Dec 20, 2017
lib/scrape.js
Outdated
| @@ -276,7 +276,7 @@ function checkGitHubUserCacheExpired(user) { | |||
| } | |||
|
|
|||
| async function freshenUserGitHubCache(user, existingUser, organization) { | |||
| if (!existingUser) { | |||
| if (!existingUser || !existingUser.github_updated) { | |||
There was a problem hiding this comment.
Minor change - I feel like this would be more elegant with !(existingUser && existingUser.github_updated).
blazeu
approved these changes
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix an issue where GitHub accounts are not updated
because they do not have a github_updated value.
Related to #93, #97