Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#29] Support GHC 9.6 #33

Merged
merged 5 commits into from
Sep 17, 2023
Merged

[#29] Support GHC 9.6 #33

merged 5 commits into from
Sep 17, 2023

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented Aug 24, 2023

Resolves #29

@vrom911 vrom911 self-assigned this Aug 24, 2023
@vrom911 vrom911 requested a review from alaendle August 24, 2023 09:57
@vrom911
Copy link
Member Author

vrom911 commented Aug 24, 2023

@alaendle please have a look!
I am going to do a release after this one, so I will write down the process andit also could be the first step for you to create releases later on as well, if you'd want to 🙂

alaendle
alaendle reviewed Aug 25, 2023
View reviewed changes
CHANGELOG.md Outdated
@@ -3,102 +3,107 @@
`co-log-core` uses [PVP Versioning][1].
The change log is available [on GitHub][2].

## 0.3.3.0 — Nov 2, 2022
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to adapt date before release is made.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@alaendle
Copy link
Member

Btw, no hurry for a new release because thanks to @Bodigrim a revision is in place that allows ghc 9.6 (see also #30 (comment)).

@vrom911
Copy link
Member Author

vrom911 commented Aug 27, 2023

Makes sense!
Do you want to add something else in the new release?
You can add the issues in the next release, so we can work on that, or just grab the things you think we can do 🙂

@alaendle
Copy link
Member

We could consider #34; not sure. Nothing to add to vNext from my side; I believe that co-log-core is in pretty good shape!

@alaendle alaendle merged commit 304f587 into main Sep 17, 2023
@alaendle alaendle deleted the vrom911/29-Support-GHC-96 branch September 17, 2023 09:13
@alaendle
Copy link
Member

Merged - but not planning a release for now - therefore I removed the version bump, cause it is unclear if the next release will contain a breaking change (0.3.3 or 0.4?). Also made a new hackage revison to allow latest doctest. https://hackage.haskell.org/package/co-log-core-0.3.2.0/revisions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaendle alaendle alaendle approved these changes

Assignees

@vrom911 vrom911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support GHC 9.6
2 participants
@vrom911 @alaendle