Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kind and its image versions in gates #1897

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

collivier
Copy link
Collaborator

Description

It updates Kind from v0.17.0 to v0.22.0 and the hardcoded v1.23.13 images to v1.23.17.

Issues:

Refs: #1886

@collivier
Copy link
Collaborator Author

@HashNuke @taylor et al. Could you please trigger workflow to see what to do next here ?

@agentpoyo
Copy link
Collaborator

@HashNuke @taylor et al. Could you please trigger workflow to see what to do next here ?

Once we get our published release working on merges, we can test this and push it through if there are no issues verifying and testing.

@HashNuke
Copy link
Collaborator

I triggered a build earlier today. I see issues in the build about not being able to get a login shell. My hunch is this is happening because the image used is based on distroless, so we might have to identify a version of the kind k8s image that isn't using distroless.

@HashNuke
Copy link
Collaborator

@collivier Could you please update this PR with the latest changes from the main branch? That should fix any build issues that aren't related to this PR.

Thanks.

Copy link
Collaborator

@HashNuke HashNuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM ~! 👍
Let me push this PR as a branch and see how the GitHub Actions build runs.

Copy link
Collaborator

@HashNuke HashNuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 3 automated tests for the security category failing in the builds. I've run them twice to confirm that these aren't random failures.

https://github.com/cnti-testcatalog/testsuite/actions/runs/8140376196/job/22256866814
https://github.com/cnti-testcatalog/testsuite/actions/runs/8140376196/job/22253010555

Please look into these failures to help take this PR forward.

@collivier
Copy link
Collaborator Author

@HashNuke yes I will have a look

It updates Kind from v0.17.0 to v0.22.0. It updates
also the hardcoded v1.23.13 images to v1.23.17.

close cnti-testcatalog#1886

Signed-off-by: Cédric Ollivier <[email protected]>
@collivier
Copy link
Collaborator Author

PR updated as asked.

@HashNuke could you please trigger a build as before to check vs latest changes. Thank you in advance.

@Smitholi67 Smitholi67 added the one summit 2024 Issue prioritized for ONE Summit (May 1) label Apr 2, 2024
@collivier
Copy link
Collaborator Author

Related to c0b0ddc

Failures:

  1) Security 'non_root_user' should pass with a non-root cnf
     Failure/Error: (/Root user not found/ =~ response_s).should_not be_nil

       Expected: nil not to be nil

     # spec/workload/security_spec.cr:13

  2) Security 'non_root_user' should fail with a root cnf
     Failure/Error: (/Root user found/ =~ response_s).should_not be_nil

       Expected: nil not to be nil

     # spec/workload/security_spec.cr:27

  3) Security 'non_root_user' should fail with a root cnf using a non-default namespace
     Failure/Error: (/Root user found/ =~ response_s).should_not be_nil

       Expected: nil not to be nil

     # spec/workload/security_spec.cr:41

Would you mind manually triggering verification please ? It was rebased on top of main and then now includes c0b0ddc

Copy link
Collaborator

@agentpoyo agentpoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and passing github actions

@agentpoyo agentpoyo merged commit a6ae8de into cnti-testcatalog:main Apr 5, 2024
109 of 190 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one summit 2024 Issue prioritized for ONE Summit (May 1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants