Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of non_root_user test #1893

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

macaktom
Copy link
Contributor

@macaktom macaktom commented Feb 15, 2024

Description

Removal of non_root_user test (removed test, spec test and documentation for this test). Other parts concerning Falco will be removed in another PR. PR for Falco will be created, after this one is merged.

Issues:

Refs: #1891

How has this been tested:

To test everything I run workload tests and all spec tests.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

@martin-mat
Copy link
Collaborator

there are still non_root_user references in
src/tasks/workload/configuration.cr (a todo comment only though)
docs/falco-config.md

but those are mostly falco-related and will be removed along with falco removal.

Thus LGTM.

Copy link
Collaborator

@HashNuke HashNuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ~! 👍

@agentpoyo agentpoyo merged commit 0483561 into cnti-testcatalog:main Feb 26, 2024
15 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants