Modularize implementation of tests #1861 #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-mat
requested review from
denverwilliams,
wvwatson and
agentpoyo
as code owners
agentpoyo
changed the title
HashNuke
approved these changes
Feb 13, 2024
martin-mat
force-pushed
the
tc_modularized
branch
2 times, most recently
from
a9b8559 to
7febb43
Compare
martin-mat
changed the title
martin-mat
force-pushed
the
tc_modularized
branch
from
7febb43 to
d3fa133
Compare
|
@martin-mat Could you please update this PR with the latest changes from the main branch and resolve conflicts? Merging latest main would also fix any build issues that aren't related to this PR. Thanks. |
Signed-off-by: Martin Matyas <[email protected]>
martin-mat
force-pushed
the
tc_modularized
branch
from
d3fa133 to
4c3b2a2
Compare
agentpoyo
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
LGTM, https://github.com/cnti-testcatalog/testsuite/actions/runs/8067488377 is passing github actions as well. If you create a pull request, we can verify and this should close out #1867
|
Merging since build is passing when pushed from a branch in the repo - https://github.com/cnti-testcatalog/testsuite/actions/runs/8067488377 |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modularized test im plementation:
centralized test result output
remove repeated code/strings/emojis from test implementation
category emojis are taken based on test category in points.yml
the adaptations require adaptation (simplification and removal of code) of every test case.
This is a WIP pull request for purpose of review of the chanegs. Only test cases in workload/observability.cr are adapted. What is missing is to adapt all remaining tests (after this one goes through the review process to avoid changing many files during the review). Do not merge for now.
note that it was also required to fix some of [BUG] wrong usage of named arguments across the code #1864 as the code stopped working after adding arguments to some methods.
also note that ResultStatus enum was moved 2 levels up in hierarchy to be better usable.
Issues:
Refs: #1861
How has this been tested:
Types of changes:
Checklist:
Documentation
Code Review
Issue