Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maintain/1841] Add log lines and organize log messages in tests #1842

Merged
merged 33 commits into from
Oct 26, 2023

Conversation

HashNuke
Copy link
Collaborator

@HashNuke HashNuke commented Oct 26, 2023

Issues: #1841

Description

  • Publish a log message when a task is started. This helps identify when test starts running for a particular CNF.
  • The task timestamps are now published to the info log irrespective of TASK_TIMESTAMPS=true being set.
  • For log messages directly within the test task, publish log messages with Log.for instead of the top-level log (Log).

Screenshot

Ran a sanity check by running the workload command with the coredns CNF.

export KIND_CLUSTER_NAME="1834-3node"
export KUBECONFIG="${PWD}/${KIND_CLUSTER_NAME}.kubeconfig"
kind create cluster --name $KIND_CLUSTER_NAME \
--kubeconfig $KUBECONFIG \
--config kind-3node.yml

./cnf-testsuite setup
./cnf-testsuite cnf_setup cnf-path=sample-cnfs/sample-coredns-cnf
./cnf-testsuite workload

CleanShot 2023-10-26 at 23 33 01@2x

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

Signed-off-by: Akash Manohar <[email protected]>
Also fix start_time value
* host_network
* service_account_mapping
* linux_hardening
* insecure_capabilities
* resource_policies
* ingress_egress_blocked
* host_pid_ipc_privileges
* non_root_containers
* task_start_time
* privileged_containers
* hostpath_mounts
* elastic_volumes
* node_drain
* database_persistence
* volume_hostpath_not_found
* no_local_volume_configuration
* rolling_update
* rolling_downgrade
* rolling_version_change
* rollback
* increase_decrease_capacity
* helm_deploy
* helm_chart_published
* helm_chart_valid
* cni_compatible
* kube_state_metrics
* node_exporter
* prometheus_adapter
* metrics_server
* k8s_conformance
* clusterapi_enabled
* worker_reboot_recovery
* control_plane_hardening
* cluster_admin
* exposed_dashboard
* open_metrics
* log_output
* prometheus_traffic
* routed_logs
* tracing
Made some changes that I missed out earlier
* liveness
* readiness
* pod_network_latency
* pod_network_corruption
* pod_network_duplication
* disk_fill
* pod_delete
* pod_memory_hog
* pod_io_stress
* pod_dns_error
Copy link
Collaborator

@agentpoyo agentpoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agentpoyo agentpoyo merged commit 8758bce into main Oct 26, 2023
187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants