Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 release v0.6.2 #79

Open
wants to merge 88 commits into
base: master
Choose a base branch
from
Open

🔖 release v0.6.2 #79

wants to merge 88 commits into from

Conversation

bunop
Copy link
Member

@bunop bunop commented Jul 11, 2024

@bunop bunop added bug Something isn't working enhancement New feature or request dependencies Pull requests that update a dependency file labels Jul 11, 2024
@bunop bunop added this to the release v0.7.0 milestone Jul 11, 2024
Copy link

github-actions bot commented Jul 11, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 02e6160

+| ✅ 104 tests passed       |+
#| ❔  49 tests were ignored |#
!| ❗   9 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

  • files_exist - File found: .gitattributes
  • files_exist - File found: .gitignore
  • files_exist - File found: .nf-core.yml
  • files_exist - File found: .editorconfig
  • files_exist - File found: .prettierignore
  • files_exist - File found: .prettierrc.yml
  • files_exist - File found: CHANGELOG.md
  • files_exist - File found: CITATIONS.md
  • files_exist - File found: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_exist - File found: nextflow_schema.json
  • files_exist - File found: nextflow.config
  • files_exist - File found: README.md
  • files_exist - File found: .github/workflows/branch.yml
  • files_exist - File found: .github/workflows/ci.yml
  • files_exist - File found: .github/workflows/linting_comment.yml
  • files_exist - File found: .github/workflows/linting.yml
  • files_exist - File found: conf/modules.config
  • files_exist - File found: conf/test.config
  • files_exist - File found: main.nf
  • files_exist - File found: assets/multiqc_config.yml
  • files_exist - File found: conf/base.config
  • files_exist - File found: modules.json
  • files_exist - File not found check: .github/ISSUE_TEMPLATE/bug_report.md
  • files_exist - File not found check: .github/ISSUE_TEMPLATE/feature_request.md
  • files_exist - File not found check: .github/workflows/push_dockerhub.yml
  • files_exist - File not found check: .nf-core.yaml
  • files_exist - File not found check: .yamllint.yml
  • files_exist - File not found check: bin/markdown_to_html.r
  • files_exist - File not found check: conf/aws.config
  • files_exist - File not found check: docs/images/nf-core-nf-resequencing-mem_logo.png
  • files_exist - File not found check: lib/Checks.groovy
  • files_exist - File not found check: lib/Completion.groovy
  • files_exist - File not found check: lib/Workflow.groovy
  • files_exist - File not found check: lib/WorkflowNf-resequencing-mem.groovy
  • files_exist - File not found check: parameters.settings.json
  • files_exist - File not found check: pipeline_template.yml
  • files_exist - File not found check: Singularity
  • files_exist - File not found check: .travis.yml
  • files_unchanged - .gitattributes matches the template
  • files_unchanged - .prettierrc.yml matches the template
  • files_unchanged - .github/workflows/branch.yml matches the template
  • files_unchanged - .github/workflows/linting_comment.yml matches the template
  • files_unchanged - .github/workflows/linting.yml matches the template
  • actions_ci - '.github/workflows/ci.yml' is triggered on expected events
  • actions_ci - '.github/workflows/ci.yml' checks minimum NF version
  • readme - README Nextflow minimum version badge matched config. Badge: 24.04.0, Config: 24.04.0
  • readme - README Zenodo placeholder was replaced with DOI.
  • plugin_includes - No wrong validation plugin imports have been found
  • template_strings - Did not find any Jinja template strings (0 files)
  • schema_lint - Schema lint passed
  • schema_lint - Schema title + description lint passed
  • schema_lint - Input mimetype lint passed: 'text/csv'
  • schema_params - Schema matched params returned from nextflow config
  • system_exit - No System.exit calls found
  • actions_schema_validation - Workflow validation passed: branch.yml
  • actions_schema_validation - Workflow validation passed: download_pipeline.yml
  • actions_schema_validation - Workflow validation passed: ci.yml
  • actions_schema_validation - Workflow validation passed: template_version_comment.yml
  • actions_schema_validation - Workflow validation passed: linting.yml
  • actions_schema_validation - Workflow validation passed: linting_comment.yml
  • actions_schema_validation - Workflow validation passed: fix-linting.yml
  • merge_markers - No merge markers found in pipeline files
  • modules_json - Only installed modules found in modules.json
  • multiqc_config - assets/multiqc_config.yml found and not ignored.
  • multiqc_config - assets/multiqc_config.yml contains report_section_order
  • multiqc_config - assets/multiqc_config.yml contains export_plots
  • multiqc_config - assets/multiqc_config.yml contains report_comment
  • multiqc_config - assets/multiqc_config.yml follows the ordering scheme of the minimally required plugins.
  • multiqc_config - assets/multiqc_config.yml contains 'export_plots: true'.
  • modules_structure - modules directory structure is correct 'modules/nf-core/TOOL/SUBTOOL'
  • base_config - conf/base.config found and not ignored.
  • base_config - FREEBAYES_CHUNK found in conf/base.config and Nextflow scripts.
  • base_config - PICARD_MARKDUPLICATES found in conf/base.config and Nextflow scripts.
  • base_config - CUSTOM_DUMPSOFTWAREVERSIONS found in conf/base.config and Nextflow scripts.
  • modules_config - conf/modules.config found and not ignored.
  • modules_config - TABIX_BGZIP found in conf/modules.config and Nextflow scripts.
  • modules_config - SAMTOOLS_FAIDX found in conf/modules.config and Nextflow scripts.
  • modules_config - CAT_FASTQ found in conf/modules.config and Nextflow scripts.
  • modules_config - FASTQC found in conf/modules.config and Nextflow scripts.
  • modules_config - SEQKIT_RMDUP_R1 found in conf/modules.config and Nextflow scripts.
  • modules_config - SEQKIT_RMDUP_R2 found in conf/modules.config and Nextflow scripts.
  • modules_config - TRIMGALORE found in conf/modules.config and Nextflow scripts.
  • modules_config - BWA_INDEX found in conf/modules.config and Nextflow scripts.
  • modules_config - BWA_MEM found in conf/modules.config and Nextflow scripts.
  • modules_config - PICARD_MARKDUPLICATES found in conf/modules.config and Nextflow scripts.
  • modules_config - SAMTOOLS_INDEX found in conf/modules.config and Nextflow scripts.
  • modules_config - SAMTOOLS_COVERAGE found in conf/modules.config and Nextflow scripts.
  • modules_config - SAMTOOLS_DEPTH found in conf/modules.config and Nextflow scripts.
  • modules_config - FREEBAYES_SPLITCRAM found in conf/modules.config and Nextflow scripts.
  • modules_config - FREEBAYES_CHUNK found in conf/modules.config and Nextflow scripts.
  • modules_config - CONCATENATE_CHROMS found in conf/modules.config and Nextflow scripts.
  • modules_config - CONCATENATE_CHROMS_TABIX found in conf/modules.config and Nextflow scripts.
  • modules_config - FREEBAYES_CONCAT found in conf/modules.config and Nextflow scripts.
  • modules_config - VCFLIB_VCFWAVE found in conf/modules.config and Nextflow scripts.
  • modules_config - BCFTOOLS_SORT found in conf/modules.config and Nextflow scripts.
  • modules_config - BCFTOOLS_NORM found in conf/modules.config and Nextflow scripts.
  • modules_config - BCFTOOLS_NORM_TABIX found in conf/modules.config and Nextflow scripts.
  • modules_config - BCFTOOLS_FILLTAGS found in conf/modules.config and Nextflow scripts.
  • modules_config - NORMALIZED_CONCAT found in conf/modules.config and Nextflow scripts.
  • modules_config - SNPEFF_DOWNLOAD found in conf/modules.config and Nextflow scripts.
  • modules_config - CUSTOM_DUMPSOFTWAREVERSIONS found in conf/modules.config and Nextflow scripts.
  • nfcore_yml - Repository type in .nf-core.yml is valid: pipeline
  • nfcore_yml - nf-core version in .nf-core.yml is set to the latest version: 3.2.0
  • version_consistency - Version tags are numeric and consistent between container, release tag and config.

Run details

  • nf-core/tools version 3.2.0
  • Run at 2025-02-05 13:08:28

bunop added 8 commits January 7, 2025 15:16
using the `dev` branch to collect files before a stable release; add a TODO section in test.config to state that the final URLs should point to master branch
remove instructions related to cloning the pipeline in a folder for simplicity
copy the current actions from an empty template
@bunop bunop modified the milestones: release v0.7.0, release v0.6.2 Jan 8, 2025
bunop and others added 10 commits January 8, 2025 15:47
bunop and others added 30 commits January 21, 2025 11:13
vcfallelicprimitives has changed is command line and now raise a warning status code which need to be catched in order to don't brake the pipeline. However, tests don't work: vcfallelicprimitives should be replaced by vcflib/vcfwave
fix issues with vcfallelicprimitives by pinning a different container version
support nextflow >= 24.10.4
change FREEBAYES_NORM to not index the received file and receiving index from CRAM_FREEBAYES_PARALLEL subworkflow
try to fix when reference is different from REF allele
attempt to solve issues with conda compilation with a custom docker container
update linting_comment CI action
🚨 solve linter issues related to VScode and nextflow languageserver
⬆️ upgrade freebayes to the latest release
The container version is more recent than conda version. Fix manually relying on environment variables
remove custom bcftools/concat module
concatenate freebayes results in one file if --save_freebayes option is provided
annotate the normalized concatenated file like previous version of this pipeline
skip normalization if skip_normalization parameter is provided
test that all gvcf parameters are defined as expected
This reverts commit 5fc0894.

Despite the current version of vcflib, vcfwave is fixed to v1.0.10. Using the version returned by the software for simplicity
🔧 configure options and conditional steps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
1 participant