Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cnoe/tools-image #179

Closed
wants to merge 1 commit into from

Conversation

jessesanford
Copy link
Contributor

Proposing we build an image rather than install stuff at runtime.

Signed-off-by: Jesse Sanford <[email protected]>
@jessesanford jessesanford requested a review from nabuskey March 19, 2024 15:01
@jessesanford
Copy link
Contributor Author

@nabuskey what do you think about this. I can clean up the commented out debug lines if you think this is a good idea. I don't see why we wouldn't just build an image?

@nabuskey
Copy link
Collaborator

nabuskey commented Mar 19, 2024

I didn't want to maintain a docker image so I just used a script to do it. Do we have automations around this?

We should also keep set e and x. When people have problems with this script, I'd hate to troubleshoot without them.

Copy link
Contributor

@cmoulliard cmoulliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to list within the upstream github repo: cnoe.io/tools-image what the image will include as tools and version !

@@ -205,7 +205,7 @@ spec:
name: config-job
containers:
- name: kubectl
image: docker.io/library/ubuntu:22.04
image: ghcr.io/cnoe-io/tools-image:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github repository which is hosting the code of the container image is empty https://github.com/cnoe-io/tools-image. Is it a mistake ? Do you plan to push the code within the repo ?

@nimakaviani
Copy link
Contributor

I am also on the side of not wanting to maintain an image for internal tools.

We already added documentation on core packages and their versions.

I am proposing that this issue can be closed.

@nabuskey
Copy link
Collaborator

nabuskey commented Jul 3, 2024

Closing this since we moved our examples to the stacks repo. Please reopen in that repo if this is still relevant.

@nabuskey nabuskey closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants