handle a case where the same directory is specified multiple times

pkg/controllers/custompackage/controller.go

@@ -190,8 +190,13 @@ func (r *Reconciler) reconcileGitRepo(ctx context.Context, resource *v1alpha1.Cu
 		}
 		return nil
 	})
+	// it's possible for an application to specify the same directory multiple times in the spec.
+	// if there is a repository already created for this package, no further action is necessary.
+	if !errors.IsAlreadyExists(err) {
+		return repo, err
+	}
 
-	return repo, err
+	return repo, nil
 }
 
 func (r *Reconciler) SetupWithManager(mgr ctrl.Manager) error {

pkg/controllers/custompackage/test/resources/customPackages/testDir/app2.yaml

@@ -8,9 +8,12 @@ spec:
     namespace: my-app2
     server: "https://kubernetes.default.svc"
   sources:
-    - repoURL: cnoe://busybox
+    - repoURL: cnoe://app2
       targetRevision: HEAD
-      path: "."
+      path: "one"
+    - repoURL: cnoe://app2
+      targetRevision: HEAD
+      path: "two"
   project: default
   syncPolicy:
     automated:

pkg/controllers/custompackage/test/resources/customPackages/testDir/app2/one/busybox.yaml

@@ -0,0 +1,17 @@
+apiVersion: v1
+kind: Pod
+metadata:
+  name: busybox
+  namespace: argocd
+  labels:
+    abc: ded
+    notused: remove-me
+spec:
+  containers:
+    - image: alpine:3.18
+      command:
+        - sleep
+        - "3600"
+      imagePullPolicy: IfNotPresent
+      name: busybox
+  restartPolicy: Always

pkg/controllers/custompackage/test/resources/customPackages/testDir/app2/two/busybox.yaml

@@ -0,0 +1,17 @@
+apiVersion: v1
+kind: Pod
+metadata:
+  name: busybox
+  namespace: argocd
+  labels:
+    abc: ded
+    notused: remove-me
+spec:
+  containers:
+    - image: alpine:3.18
+      command:
+        - sleep
+        - "3600"
+      imagePullPolicy: IfNotPresent
+      name: busybox
+  restartPolicy: Always