Decrease number of logs during cnf_install and cnf_uninstall #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Commit updated shard.lock after running 'shards install' - Add new constant for repeated logs interval Signed-off-by: Rafal Lal <[email protected]>
svteb
reviewed
Feb 10, 2025
| @@ -1059,32 +1059,36 @@ module KubectlClient | |||
| is_ready = resource_ready?(kind, namespace, resource_name, kubeconfig) | |||
|
|
|||
| until is_ready || second_count > wait_count | |||
| Log.info { "KubectlClient::Get.resource_wait_for_install attempt: #{second_count}; is_ready: #{is_ready}" } | |||
| if second_count % RESOURCE_WAIT_LOG_INTERVAL == 0 | |||
| Log.info { "KubectlClient::Get.resource_wait_for_install seconds elapsed: #{second_count}; is_ready: #{is_ready}" } | |||
There was a problem hiding this comment.
Could this be scoped through Log.for instead with a clearer message? The KubectlClient::Get.resource_wait_for_install part is a bit jarring.
There was a problem hiding this comment.
I'm working on the log refactor in other PR, wanted to post a quick fix here.
| until (resource_uninstalled && resource_uninstalled.as_h == empty_hash) || second_count > wait_count | ||
| Log.info { "second_count = #{second_count}" } | ||
| if second_count % RESOURCE_WAIT_LOG_INTERVAL == 0 | ||
| Log.info { "KubectlClient::Get.resource_wait_for_uninstall seconds elapsed: #{second_count}" } |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR that addresses looped logs during cnf install.