-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large build system and small API modernizations #250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make doxygen not required?
Sure, in theory it isn’t but there might be some cmake magic needed.
Likewise for swig…
Le mer. 8 juin 2022 à 15:42, Kevin Lenzo ***@***.***> a
écrit :
… ***@***.**** commented on this pull request.
Can you make doxygen not required?
—
Reply to this email directly, view it on GitHub
<#250 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZLYUECNKXW32SQHO7MKSDVODZS7ANCNFSM5YHULO5Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
should be done in 561a4b1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions
I'm using pyenv, and cmake seems to get a little confused about which SDK to build for -- it complains (but works) at link time about the python version and the current build target. We can figure this out later...
... and more like that. |
Ideally this would be a couple different PRs. It:
The goal is to get a truly stable release since PocketSphinx is no longer a development system.