Rebase on main

cmu-db · Nov 9, 2024 · 7a8d4df · 7a8d4df
1 parent 6f97425
commit 7a8d4df
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/optd-persistent/Cargo.lock b/optd-persistent/Cargo.lock
diff --git a/optd-persistent/src/cost_model/orm.rs b/optd-persistent/src/cost_model/orm.rs
@@ -318,6 +318,9 @@ impl CostModelStorageLayer for BackendManager {
             .await?;
 
         // TODO(lanlou): consider the update conflict for latest_epoch_id in multiple threads
+        // Assume the txn fails to commit, and the epoch_id is updated. But the epoch_id
+        // is always increasing and won't be overwritten even if the record is deleted, it
+        // might be fine.
         if insert_new_epoch {
             self.latest_epoch_id
                 .store(epoch_id as usize, std::sync::atomic::Ordering::Relaxed);